Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved feedback widget behind env variables #562

Merged

Conversation

awais-ansari
Copy link
Contributor

INF-1040

  • backport PR for palm release
  • Moved the feedback widget behind the env variables.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01% 🎉

Comparison is base (dcb0f9e) 92.38% compared to head (4e94ac5) 92.40%.
Report is 1 commits behind head on open-release/palm.master.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #562      +/-   ##
============================================================
+ Coverage                     92.38%   92.40%   +0.01%     
============================================================
  Files                           163      162       -1     
  Lines                          3297     3278      -19     
  Branches                        890      883       -7     
============================================================
- Hits                           3046     3029      -17     
+ Misses                          232      230       -2     
  Partials                         19       19              
Files Changed Coverage Δ
...c/discussions/discussions-home/DiscussionsHome.jsx 94.73% <ø> (-0.27%) ⬇️
src/discussions/messages.js 100.00% <ø> (ø)
src/index.jsx 0.00% <ø> (ø)
...c/discussions/discussions-home/FeedbackWrapper.jsx 92.85% <50.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 2abe4df into open-release/palm.master Sep 8, 2023
5 of 6 checks passed
@awais-ansari awais-ansari deleted the aansari/revert-feedback-widget branch September 8, 2023 13:40
vunguyen-dmt added a commit to vunguyen-dmt/frontend-app-discussions that referenced this pull request Oct 20, 2023
fix: moved feedback widget behind env variables (openedx#562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants