Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated lock file version check to use new workflow #559

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Aug 25, 2023

Description

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Ticket

Prototype a way to review NPM lockfiles in PRs

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@abdullahwaheed abdullahwaheed changed the title refactor: update lock file version refactor: updated lock file version check to use new workflow Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4994de9) 92.37% compared to head (e79ad9a) 92.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         169      169           
  Lines        3450     3450           
  Branches      898      898           
=======================================
  Hits         3187     3187           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari
Copy link
Contributor

Hi @Mashal-m, Just to confirm. Are you still working on this PR? We are planning the board cleanup. Should I close this PR?

@sundasnoreen12
Copy link
Contributor

Hi @Mashal-m any updates on this PR?

@Mashal-m
Copy link
Contributor Author

Mashal-m commented Nov 8, 2023

It is ready to review and merge.

Hi @Mashal-m any updates on this PR?

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@sundasnoreen12 sundasnoreen12 merged commit 6930e90 into master Nov 8, 2023
7 checks passed
@sundasnoreen12 sundasnoreen12 deleted the mashal-m/update_lockfile branch November 8, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants