Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Readme updated according OEP-55 #141

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

johnvente
Copy link
Contributor

The README of the MFE's need to be updated because the frontend app template has been updated

Issue related: openedx/wg-frontend#169

@openedx-webhooks
Copy link

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 28, 2023
@johnvente johnvente changed the title [DOCS] README updated [DOCS] Readme updated according OEP-55 Jun 28, 2023
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this update! Just needs a few tiny fixes to some links for this to be good to go.

@johnvente
Copy link
Contributor Author

Thanks for submitting this update! Just needs a few tiny fixes to some links for this to be good to go.

Thanks for the review! I have done the fixes 😄

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing the things I pointed out! Looks good to me. I'll go ahead and merge this shortly!

@justinhynes justinhynes merged commit ce45c80 into openedx:master Jul 7, 2023
@openedx-webhooks
Copy link

@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

snglth pushed a commit to Abstract-Tech/community-theme-communications that referenced this pull request Jan 9, 2024
* docs: readme updated with frontend-template-app readme ref
* fix: change main branch to master, spelling and getting help url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants