Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search filters refinement #980

Merged

Conversation

yusuf-musleh
Copy link
Contributor

@yusuf-musleh yusuf-musleh commented May 6, 2024

Description

This fixes a visual bug and sorts the blocktypes in the search filters.

Based on openedx/modular-learning#211

  1. the number is not visible next to longer filter names (see “Open Response Assessmen...” below.

Dropdown expands to show fullname + count:

Screenshot 2024-05-06 at 5 18 54 PM
  1. Please order the options in the type filter by hierarchy:
    Section
    Subsection
    Unit
    and then the components in whichever order (perhaps alphabetical)

Dropdown blocktypes are sorted, section -> subsection -> unit -> [the rest alphabetically]:

Screenshot 2024-05-06 at 5 18 37 PM

Supporting information

Related Ticket:

Testing instructions

  1. Run this branch in your local tutor
  2. Make sure you have sample taxonomy/tags setup
  3. Make sure you have https://github.com/open-craft/tutor-contrib-meilisearch/ enabled
  4. Click on the search icon at the top of the page
  5. Confirm the 2 changes described above

Private-ref: FAL-3718

@openedx-webhooks
Copy link

openedx-webhooks commented May 6, 2024

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 6, 2024
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/search-filters-refinement branch from 3301027 to 4709c03 Compare May 6, 2024 14:38
@yusuf-musleh yusuf-musleh marked this pull request as ready for review May 6, 2024 14:48
@yusuf-musleh yusuf-musleh requested a review from a team as a code owner May 6, 2024 14:48
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good, but I added a nit 👍

  • I tested this: I followed the testing instructions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes documentation

src/search-modal/FilterByBlockType.jsx Outdated Show resolved Hide resolved
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/search-filters-refinement branch from 4709c03 to 0b0e248 Compare May 7, 2024 12:19
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.22%. Comparing base (087c82c) to head (279b39d).

Files Patch % Lines
src/search-modal/FilterByBlockType.jsx 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   92.21%   92.22%           
=======================================
  Files         703      703           
  Lines       12361    12373   +12     
  Branches     2682     2647   -35     
=======================================
+ Hits        11399    11411   +12     
  Misses        926      926           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/search-filters-refinement branch from 0b0e248 to 279b39d Compare May 8, 2024 15:54
bradenmacdonald added a commit to open-craft/frontend-app-authoring that referenced this pull request May 8, 2024
@pomegranited
Copy link
Contributor

Calling all CCs on this repo: @brian-smith-tcril @arbrandes @viktorrusakov @xitij2000
Does anyone have time to approve and merge this before Redwood gets cut? Thank you :)

@xitij2000
Copy link
Contributor

Calling all CCs on this repo: @brian-smith-tcril @arbrandes @viktorrusakov @xitij2000 Does anyone have time to approve and merge this before Redwood gets cut? Thank you :)

I'm looking into it.

@xitij2000 xitij2000 merged commit 8aea28c into openedx:master May 9, 2024
6 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the yusuf-musleh/search-filters-refinement branch May 9, 2024 05:40
@pomegranited
Copy link
Contributor

Thank you @xitij2000 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Course Search] Refinements to search modal UX
5 participants