-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search filters refinement #980
feat: search filters refinement #980
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
3301027
to
4709c03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yusuf-musleh Looks good, but I added a nit 👍
- I tested this: I followed the testing instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes documentation
4709c03
to
0b0e248
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
=======================================
Coverage 92.21% 92.22%
=======================================
Files 703 703
Lines 12361 12373 +12
Branches 2682 2647 -35
=======================================
+ Hits 11399 11411 +12
Misses 926 926
Partials 36 36 ☔ View full report in Codecov by Sentry. |
0b0e248
to
279b39d
Compare
…xonomy-sandbox-20240508
Calling all CCs on this repo: @brian-smith-tcril @arbrandes @viktorrusakov @xitij2000 |
I'm looking into it. |
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thank you @xitij2000 ! |
Description
This fixes a visual bug and sorts the blocktypes in the search filters.
Based on openedx/modular-learning#211
Dropdown expands to show fullname + count:
Dropdown blocktypes are sorted, section -> subsection -> unit -> [the rest alphabetically]:
Supporting information
Related Ticket:
Testing instructions
Private-ref: FAL-3718