Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FC-0036] refactor: Further refinements to tag drawer #970

Merged
merged 2 commits into from
May 6, 2024
Merged

[FC-0036] refactor: Further refinements to tag drawer #970

merged 2 commits into from
May 6, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Apr 30, 2024 •
edited
Loading

Description

  • Padding to top and left tagging drawer
  • Changes in headings in the tagging drawer

Supporting information

Testing instructions

  • Make sure you have some sample taxonomy/tags data setup: https://github.com/open-craft/taxonomy-sample-data

  • Go to studio > one course and open the mange tags of any section/unit.

  • Check this changes:

    • Please increase the padding around the top and sides of the tagging drawer (it can be increased by 50-100%).

    • The H2 should be kept as <h2> but should look like an H3

    • The “Manage tags” heading should match the size of the H4 (18px)

    • The Taxonomies headings should should be H3 (not H4) since the next heading above them (the unit name) is H2. However, please change them to look visually like H5.

@ChrisChV
refactor: Further refinements to tag drawer
3ded311 
* Padding to top and left tagging drawer
* Changes in headings in the tagging drawer
@ChrisChV ChrisChV requested a review from a team as a code owner April 30, 2024 18:15
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 30, 2024
@ChrisChV ChrisChV changed the title refactor: Further refinements to tag drawer [FC-0036] refactor: Further refinements to tag drawer Apr 30, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (a9a73ef) to head (6e959bb).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   92.12%   92.21%   +0.09%     
==========================================
  Files         685      703      +18     
  Lines       12133    12359     +226     
  Branches     2642     2677      +35     
==========================================
+ Hits        11177    11397     +220     
- Misses        920      926       +6     
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yusuf-musleh
yusuf-musleh approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Looks good to me, great work!

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

xitij2000
xitij2000 approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits about using existing classes instead of creating new ones. After that this is good to merge.

src/content-tags-drawer/ContentTagsDrawer.scss Outdated
@@ -9,6 +9,10 @@
}

.tags-drawer {
.tags-drawer-heading {
font-size: 1.375rem !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the font size of h3, you can use the h3 class name to apply that style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: 6e959bb

src/content-tags-drawer/ContentTagsDrawer.scss Outdated
@@ -18,6 +22,14 @@
background-color: transparent;
color: $gray-300 !important;
}

.tags-drawer-subtitle {
font-size: 1.125rem !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise you can use h4 as a class here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 6e959bb

src/content-tags-drawer/ContentTagsDrawer.scss Outdated
}

.tags-drawer-taxonomy-name {
font-size: .875rem !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is h5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 6e959bb

@ChrisChV
Copy link
Contributor Author

ChrisChV commented May 3, 2024

@xitij2000 It's ready for another review

@xitij2000 xitij2000 merged commit de408b5 into openedx:master May 6, 2024
6 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the chris/FAL-3719-some-refinements-tag-drawer branch May 6, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xitij2000 xitij2000 xitij2000 approved these changes

@yusuf-musleh yusuf-musleh yusuf-musleh approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tagging] Further refinements to tag drawer
4 participants
@ChrisChV @openedx-webhooks @xitij2000 @yusuf-musleh