Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0044] Unit page - manage tags xblocks #967

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Apr 27, 2024

Description

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS:
  MFE_CONFIG:
    ENABLE_UNIT_PAGE: true

In this PR:

  1. added the tag counter for each component on the Course Unit page;
  2. added "Manage Tags" menu item with handler to open/close Tags menu;
  3. reordered menu items due to this issue.

Testing instructions

  • Run master devstack.
  • Start platform make dev.up.lms+cms+frontend-app-course-authoring and make checkout on this branch.
  • Enable the new Unit page by adding a waffle flag contentstore.new_studio_mfe.use_new_unit_page in the CMS admin panel.
  • Go to the Course Unit page from the Course Outline page.
  • Add a new xblock component.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 27, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 27, 2024

Thanks for the pull request, @khudym!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (3a14141) to head (2b2abf6).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   92.68%   92.69%   +0.01%     
==========================================
  Files         693      694       +1     
  Lines       12346    12364      +18     
  Branches     2661     2708      +47     
==========================================
+ Hits        11443    11461      +18     
  Misses        872      872              
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch 3 times, most recently from d272df7 to 9f76ddc Compare May 3, 2024 20:34
@mphilbrick211
Copy link

@khudym @GlugovGrGlib is this still in progress?

@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch 2 times, most recently from 13c467f to 92939bb Compare July 22, 2024 22:15
@khudym khudym force-pushed the hudym/Unit-page-manage-tags-xblocks branch from 92939bb to 2b2abf6 Compare July 22, 2024 22:24
@khudym khudym marked this pull request as ready for review July 22, 2024 22:38
@khudym khudym requested a review from a team as a code owner July 22, 2024 22:38
@khudym
Copy link
Contributor Author

khudym commented Jul 22, 2024

@mphilbrick211 its ready for review!

@mphilbrick211
Copy link

@openedx/2u-tnl this is all set for review!

@mphilbrick211
Copy link

Apologies, @openedx/2u-tnl - this project is closed, so we're going to move this to a draft for reference on related work.

@mphilbrick211 mphilbrick211 removed the request for review from a team July 25, 2024 18:03
@arbrandes arbrandes marked this pull request as draft July 25, 2024 18:15
@mphilbrick211
Copy link

[Inform] This PR will remain open as a draft for reference until the community decides the best way to tackle the problem

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants