-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0044] Unit page - refactoring unit page breadcrumbs and actions #827
feat: [FC-0044] Unit page - refactoring unit page breadcrumbs and actions #827
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
99c9339
to
fa50334
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
==========================================
- Coverage 89.13% 89.10% -0.04%
==========================================
Files 548 547 -1
Lines 9647 9629 -18
Branches 2067 2061 -6
==========================================
- Hits 8599 8580 -19
- Misses 1001 1002 +1
Partials 47 47 ☔ View full report in Codecov by Sentry. |
23aa273
to
54f1797
Compare
Just need to create sandbox and test it on there. After checking it works there, the PR can be merged |
54f1797
to
cd2d0bf
Compare
Sandbox deployment failed. Check failure logs here https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-827-ba9a65-51564656-6148611363.log Instance Tutor config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-827-ba9a65-51564656-6148611363-tutor-config.yml Please check the settings and requirements and retry deployment by updating the pull request description or pushing a new commit |
@arbrandes I tried to create a sandbox as you recommended but faced with some problem. |
Sandbox deployment successful. Sandbox LMS is available at https://pr-827-ba9a65.sandboxes.opencraft.hosting Instance Tutor config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-827-ba9a65-51564656-6157960519-tutor-config.yml |
@KristinAoki Sandbox is ready for testing. |
Sandbox deployment successful. Sandbox LMS is available at https://pr-827-ba9a65.sandboxes.opencraft.hosting Instance Tutor config : https://axim-sandbox-build-logs-4626178240.nyc3.digitaloceanspaces.com/pr-827-ba9a65-51564656-6173132458-tutor-config.yml |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Settings
Description
This pull request addresses the refactoring of the breadcrumbs section and the preview buttons ("View live version" and "Preview") within the Unit page. The primary focus is on simplifying the existing codebase and optimizing the usage of data retrieved from the API endpoint.
Issue: openedx/platform-roadmap#321
Benefits
Developer notes
The first three commits in this pull request are temporary. Once the #809 is merged, the fourth commit of this pull request will become the main commit.
Design
https://www.figma.com/file/YeKFwSpyLaJFDs3f3p3TSa/Studio-1%3A1-mock-ups?node-id=599%3A23595
Testing instructions
contentstore.new_studio_mfe.use_new_unit_page
in CMS admin panel.