fix: fidelity typo in preference api #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested review from
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
KristinAoki
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
==========================================
+ Coverage 88.02% 88.20% +0.17%
==========================================
Files 417 417
Lines 6598 6602 +4
Branches 1428 1430 +2
==========================================
+ Hits 5808 5823 +15
+ Misses 765 755 -10
+ Partials 25 24 -1
☔ View full report in Codecov by Sentry. |
rayzhou-bit
approved these changes
Nov 7, 2023
| @@ -573,6 +573,39 @@ describe('TranscriptSettings', () => { | |||
|
|
|||
| expect(screen.getByText('Failed to update 3PlayMedia transcripts settings.')).toBeVisible(); | |||
| }); | |||
|
|
|||
| it('should show error alert wit default message on 3PlayMedia preferences update', async () => { | |||
| @@ -541,7 +541,7 @@ describe('TranscriptSettings', () => { | |||
| expect(screen.getByText('Failed to update Cielo24 transcripts settings.')).toBeVisible(); | |||
| }); | |||
|
|
|||
| it('should show error alert on 3PlayMedia preferences update', async () => { | |||
| it('should show error alert wit default message on 3PlayMedia preferences update', async () => { | |||
Ian2012
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the typo in the
transcript_preferencesapi. Previous the json passed to the api wasAs a result the api threw an error because it was expecting
cielo24_fidelityinstead ofcielo24_fideltiy.