-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use modifyObjectKeys and snakeCaseObject on api data advanced settings to format values #1581
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @jignaciopm! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
…ttings to format value
42e21ab
to
3cb49ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1581 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 1075 1075
Lines 21205 21213 +8
Branches 4562 4492 -70
=======================================
+ Hits 19715 19723 +8
Misses 1424 1424
Partials 66 66 ☔ View full report in Codecov by Sentry. |
…ttings to format value cherry-pick from: openedx#1581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
Looks like this is blocked waiting for a review from @openedx/2u-tnl. Do you guys think you could take a look? |
Description
This PR fixes this bug and this bug.
Testing instructions
camelCase
(Review any field whose value is an object with configuration keys).BEFORE
AFTER