-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete collection #1333
base: master
Are you sure you want to change the base?
feat: delete collection #1333
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
2ebdce8
to
9f9e537
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
+ Coverage 92.72% 92.74% +0.01%
==========================================
Files 1036 1036
Lines 19351 19411 +60
Branches 4036 4097 +61
==========================================
+ Hits 17944 18002 +58
+ Misses 1343 1342 -1
- Partials 64 67 +3 ☔ View full report in Codecov by Sentry. |
// Set timeout to 10 seconds if action is set else close in 5 seconds. | ||
const timeout = toastAction ? 10 * 1000 : 5 * 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toast is displayed a bit longer when it has an action attached.
Description
Adds delete option to collection card menu. It displays a confirmation box before deleting and a toast with button to undo delete action for 10 seconds.
Supporting information
Testing instructions
Concerns
Adding the undo button in a toast doesn't seem the best option in terms of accessibility.