refactor!: turn on homepage course API V2 consumption by default #1307
Conversation
Turn on getting courses from the HomePageCourses API which allows pagination, filtering and ordering. See openedx/edx-platform#34173 for more details on the API implementation.
|
Thanks for the pull request, @mariajgrimaldi! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1307 +/- ##
==========================================
+ Coverage 92.47% 92.49% +0.02%
==========================================
Files 1025 1031 +6
Lines 18979 19112 +133
Branches 4036 4055 +19
==========================================
+ Hits 17551 17678 +127
- Misses 1360 1369 +9
+ Partials 68 65 -3 ☔ View full report in Codecov by Sentry. |
|
Hello folks, @jesperhodge @bradenmacdonald @jmakowski1123. I'm tagging you here for visibility to address Braden's comment in the product proposal post. Please let me know if you agree with the changes. Thanks. Also, Braden, can we get a sandbox to test this change? |
bradenmacdonald
added
the
create-sandbox
|
Thanks @mariajgrimaldi. I'm good with this change. I'm also hoping we can follow it up in a few weeks by removing the setting and removing the code for loading it from the old API too, because I don't like having two different code paths if we don't need to. I've requested a sandbox, but since you're from another org there may be an additional step required to get it to work. I'll follow up if needed. |
|
By the way: with or without this change, there is still a bug that the course list on the homepage is not sorted (in any way) by default. It says it's sorted "A-Z" but unless you change the sorting, it is not actually sorted. Notice below that "Alpha" should come before "Beta".
|
|
Thanks, @bradenmacdonald. I'll be working on the next steps for the flag removal. As for the bug, I'll ask someone from my team to take a look :) |
|
Hi, @bradenmacdonald I made a change to sort the courses initially by A-Z. Could you have a look? |
There was a problem hiding this comment.
LGTM! And the home page sort is now working properly :)
I'll need @KristinAoki or someone from 2U to approve this before we merge it though. I'm not sure of the context on why this API hasn't been switched on already.
|
Sandbox deployment successful 🚀 |
|
@mariajgrimaldi Here is a sandbox for you ^ Edit: spoke too soon; there is some issue with the sandbox |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
@bradenmacdonald, thank you! I've tested it, and it's working fine :) |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
Description
Turn on getting courses from the HomePageCourses API which allows pagination, filtering and ordering. See openedx/edx-platform#34173 for more details on the API implementation.
When we implemented #846, we agreed to turn this feature back on once Redwood was cut, so this change is long overdue.
Supporting information
Please, see https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4032856101/Studio+Home+incremental+upgrades+-+product+approach
Testing instructions
This view should be on by default after this change:
