test: Remove support for Node 18

[BilalQamar95]

Note: As per openedx/public-engineering#280 this can merge this after Sumac is cut.

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (ecfe27b) to head (b2ca0cd).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1247   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files        1052     1052           
  Lines       20458    20458           
  Branches     4382     4382           
=======================================
  Hits        19078    19078           
  Misses       1317     1317           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bradenmacdonald]

@BilalQamar95 Is this ready to merge, or are we waiting for something? And do you know why it's still showing "tests (18) Expected — Waiting for status to be reported" on the CI report here on GitHub?

[BilalQamar95]

@BilalQamar95 Is this ready to merge, or are we waiting for something?

It was recently brought to my attention that there was openedx/public-engineering#280. After the Sumac cut, PRs removing Node 18 from the CI matrix can be merged.

And do you know why it's still showing "tests (18) Expected — Waiting for status to be reported" on the CI report here on GitHub?

It is due to test that runs on Node 18. tests (18) is a required check in the CI which needs to be removed.

[bradenmacdonald]

@BilalQamar95 CC @brian-smith-tcril Just noting that this will need a slight update before merge, due to changes in how coverage tests are now run.

frontend-app-authoring/.github/workflows/validate.yml

Lines 25 to 27 in cff1177

	name: code-coverage-report-${{ matrix.node }}
	# When we're only using Node 20, replace the line above with the following:
	# name: code-coverage-report

frontend-app-authoring/.github/workflows/validate.yml

Lines 37 to 39 in cff1177

	name: code-coverage-report-20
	# When we're only using Node 20, replace the line above with the following:
	# name: code-coverage-report