Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save discussion alert dismissal #1245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Aug 30, 2024

Description

The alert used to inform about the usage of an upgraded version of discussion forum still shows on refresh after being dismissed. The goal of this PR is correct that and save the dismissal per course.

Testing instruction

  • Clone this repository and run npm insall
  • Ensure your are running Tutor redwood locally (>= 18)
  • Mount the clone repository to Tutor using tutor mounts add your/path/to/frontend-app-course-authoring
  • Run tutor dev launch
  • To simplify testing and show the Alert, comment out the following or set the condition to be always false.
if (providerType !== 'openedx') {
     return null;
   }
  • Dismiss the Alert then refresh. The alert will show again
  • Checkout this PR's branch then run npm install
  • Now after dismissal and refresh, the alert shouldn't show.

ref

BB-9079

@CefBoud CefBoud requested a review from a team as a code owner August 30, 2024 14:28
@openedx-webhooks
Copy link

Thanks for the pull request, @CefBoud!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@KristinAoki
Copy link
Member

@CefBoud can you check out the failing test? It does not appear to be connected to your changes so this branch may need to be updated with the main branch.

@bradenmacdonald
Copy link
Contributor

That test in LibraryAuthoringPage.test.tsx has been flaky. I have completely refactored it, but it still may be flaky. If you see it failing again after rebasing, please let me know and I'll disable it until we get to the root cause. For now I think rebasing should work.

@CefBoud CefBoud force-pushed the cef/save-discussion-alert-dismissal branch from b1f2c47 to 11799cf Compare September 13, 2024 13:36
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (fd48fef) to head (11799cf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files        1013     1013           
  Lines       18733    18735    +2     
  Branches     3947     4008   +61     
=======================================
+ Hits        17293    17296    +3     
+ Misses       1374     1370    -4     
- Partials       66       69    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants