-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: save discussion alert dismissal #1245
base: master
Are you sure you want to change the base?
feat: save discussion alert dismissal #1245
Conversation
Thanks for the pull request, @CefBoud! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@CefBoud can you check out the failing test? It does not appear to be connected to your changes so this branch may need to be updated with the main branch. |
That test in |
b1f2c47
to
11799cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 1013 1013
Lines 18733 18735 +2
Branches 3947 4008 +61
=======================================
+ Hits 17293 17296 +3
+ Misses 1374 1370 -4
- Partials 66 69 +3 ☔ View full report in Codecov by Sentry. |
Description
The alert used to inform about the usage of an upgraded version of discussion forum still shows on refresh after being dismissed. The goal of this PR is correct that and save the dismissal per course.
Testing instruction
npm insall
tutor mounts add your/path/to/frontend-app-course-authoring
tutor dev launch
npm install
ref
BB-9079