Skip to content

Commit

Permalink
refactor: tests refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
PKulkoRaccoonGang committed May 7, 2024
1 parent c433bc0 commit eeadefe
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 13 deletions.
5 changes: 2 additions & 3 deletions src/course-unit/CourseUnit.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ const CourseUnit = ({ courseId }) => {

const initialXBlocksData = useMemo(() => courseVerticalChildren.children ?? [], [courseVerticalChildren.children]);
const [unitXBlocks, setUnitXBlocks] = useState(initialXBlocksData);
// const unitData = useSelector(state => state.courseUnit);
// console.log('unitData ===>', unitData);

useEffect(() => {
document.title = getPageHeadTitle('', unitTitle);
}, [unitTitle]);
Expand All @@ -99,7 +98,7 @@ const CourseUnit = ({ courseId }) => {
</Container>
);
}
console.log('movedXBlockParams =======>', movedXBlockParams);

const finalizeXBlockOrder = () => (newXBlocks) => {
handleXBlockDragAndDrop(newXBlocks.map(xBlock => xBlock.id), () => {
setUnitXBlocks(initialXBlocksData);
Expand Down
7 changes: 5 additions & 2 deletions src/course-unit/CourseUnit.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,17 @@ import {
} from './data/thunk';
import initializeStore from '../store';
import {
clipboardMockResponse,
courseCreateXblockMock,
courseSectionVerticalMock,
courseUnitIndexMock,
courseUnitMock,
courseVerticalChildrenMock,
clipboardMockResponse,
} from './__mocks__';
import { clipboardUnit, clipboardXBlock } from '../__mocks__';
import {
clipboardUnit,
clipboardXBlock,
} from '../__mocks__';
import { executeThunk } from '../utils';
import deleteModalMessages from '../generic/delete-modal/messages';
import pasteComponentMessages from '../generic/clipboard/paste-component/messages';
Expand Down
4 changes: 2 additions & 2 deletions src/course-unit/course-xblock/CourseXBlock.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ import { EditOutline as EditIcon, MoreVert as MoveVertIcon } from '@openedx/para
import { useIntl } from '@edx/frontend-platform/i18n';
import { useNavigate, useSearchParams } from 'react-router-dom';

import { getCanEdit, getCourseId } from '../data/selectors';
import { useOverflowControl } from '../../generic/hooks';
import DeleteModal from '../../generic/delete-modal/DeleteModal';
import ConfigureModal from '../../generic/configure-modal/ConfigureModal';
import SortableItem from '../../generic/drag-helper/SortableItem';
import { scrollToElement } from '../../course-outline/utils';
import { COURSE_BLOCK_NAMES } from '../../constants';
import { getCanEdit, getCourseId } from '../data/selectors';
import { copyToClipboard } from '../../generic/data/thunks';
import { fetchCourseUnitQuery, fetchCourseVerticalChildrenData } from '../data/thunk';
import { updateMovedXBlockParams } from '../data/slice';
Expand Down Expand Up @@ -48,7 +48,7 @@ const CourseXBlock = ({
useEffect(() => {
const handleMessage = (event) => {
const { method, params } = event.data;
console.log('method ===>', method);

if (method === 'close_modal') {
toggleLegacyEditModal(false);
dispatch(fetchCourseVerticalChildrenData(blockId));
Expand Down
4 changes: 1 addition & 3 deletions src/course-unit/data/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ export const postXBlockBaseApiUrl = () => `${getStudioBaseUrl()}/xblock/`;
* @returns {Promise<Object>}
*/
export async function getCourseUnitData(unitId) {

const { data } = await getAuthenticatedHttpClient()
.get(getCourseUnitApiUrl(unitId));
console.log('getCourseUnitData', data);

return camelCaseObject(data);
}

Expand Down Expand Up @@ -157,7 +156,6 @@ export async function duplicateUnitItem(itemId, XBlockId) {
* @returns {Promise<any>} - A promise that resolves to the response data from the server.
*/
export async function rollbackUnitItem(itemId, xblockId) {
console.log('HELLOOOOOOOOO');
const { data } = await getAuthenticatedHttpClient()
.patch(postXBlockBaseApiUrl(), {
parent_locator: itemId,
Expand Down
4 changes: 1 addition & 3 deletions src/course-unit/data/thunk.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,12 @@ export function rollbackUnitItemQuery(itemId, xblockId, title) {
await rollbackUnitItem(itemId, xblockId);
const newCourseVerticalChildren = await getCourseVerticalChildren(itemId);
dispatch(updateCourseVerticalChildren(newCourseVerticalChildren));
dispatch(updateMovedXBlockParams({ title, isSuccess: true, isUndo: true }));
const courseUnit = await getCourseUnitData(itemId);

dispatch(fetchCourseItemSuccess(courseUnit));
dispatch(hideProcessingNotification());
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
dispatch(updateMovedXBlockParams({ title, isSuccess: true, isUndo: true }));
} catch (error) {
console.log('HEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEYHEY', error);
dispatch(hideProcessingNotification());
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
}
Expand Down

0 comments on commit eeadefe

Please sign in to comment.