refactor: remove unused libraryId param

openedx · Sep 26, 2024 · b43d902 · b43d902
1 parent ccce44a
commit b43d902
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 22 deletions.
diff --git a/src/library-authoring/LibraryAuthoringPage.tsx b/src/library-authoring/LibraryAuthoringPage.tsx
@@ -205,7 +205,7 @@ const LibraryAuthoringPage = () => {
               />
               <Route
                 path={TabList.components}
-                element={<LibraryComponents libraryId={libraryId} variant="full" />}
+                element={<LibraryComponents variant="full" />}
               />
               <Route
                 path={TabList.collections}

diff --git a/src/library-authoring/LibraryHome.tsx b/src/library-authoring/LibraryHome.tsx
@@ -52,7 +52,7 @@ const LibraryHome = ({ libraryId, tabList, handleTabChange } : LibraryHomeProps)
               contentCount={componentCount}
               viewAllAction={() => handleTabChange(tabList.components)}
             >
-              <LibraryComponents libraryId={libraryId} variant="preview" />
+              <LibraryComponents variant="preview" />
             </LibrarySection>
           </>
         )

diff --git a/src/library-authoring/LibraryRecentlyModified.tsx b/src/library-authoring/LibraryRecentlyModified.tsx
@@ -8,10 +8,9 @@ import { type CollectionHit, type ContentHit, SearchSortOption } from '../search
 import LibrarySection, { LIBRARY_SECTION_PREVIEW_LIMIT } from './components/LibrarySection';
 import messages from './messages';
 import ComponentCard from './components/ComponentCard';
-import { useLibraryBlockTypes } from './data/apiHooks';
 import CollectionCard from './components/CollectionCard';
 
-const RecentlyModified: React.FC<{ libraryId: string }> = ({ libraryId }) => {
+const RecentlyModified = () => {
   const intl = useIntl();
   const {
     hits,
@@ -31,17 +30,6 @@ const RecentlyModified: React.FC<{ libraryId: string }> = ({ libraryId }) => {
     ...collectionList,
   ], ['modified'], ['desc']).slice(0, LIBRARY_SECTION_PREVIEW_LIMIT);
 
-  const { data: blockTypesData } = useLibraryBlockTypes(libraryId);
-  const blockTypes = useMemo(() => {
-    const result = {};
-    if (blockTypesData) {
-      blockTypesData.forEach(blockType => {
-        result[blockType.blockType] = blockType;
-      });
-    }
-    return result;
-  }, [blockTypesData]);
-
   return componentCount > 0
     ? (
       <LibrarySection
@@ -82,7 +70,7 @@ const LibraryRecentlyModified: React.FC<{ libraryId: string }> = ({ libraryId })
     extraFilter={`context_key = "${libraryId}"`}
     overrideSearchSortOrder={SearchSortOption.RECENTLY_MODIFIED}
   >
-    <RecentlyModified libraryId={libraryId} />
+    <RecentlyModified />
   </SearchContextProvider>
 );
 

diff --git a/src/library-authoring/collections/LibraryCollectionComponents.tsx b/src/library-authoring/collections/LibraryCollectionComponents.tsx
@@ -6,7 +6,7 @@ import { LibraryComponents } from '../components';
 import messages from './messages';
 import { LibraryContext } from '../common/context';
 
-const LibraryCollectionComponents = ({ libraryId }: { libraryId: string }) => {
+const LibraryCollectionComponents = () => {
   const { totalHits: componentCount, isFiltered } = useSearchContext();
   const { openAddContentSidebar } = useContext(LibraryContext);
 
@@ -25,7 +25,7 @@ const LibraryCollectionComponents = ({ libraryId }: { libraryId: string }) => {
   return (
     <Stack direction="vertical" gap={3}>
       <h3 className="text-gray">Content ({componentCount})</h3>
-      <LibraryComponents libraryId={libraryId} variant="full" />
+      <LibraryComponents variant="full" />
     </Stack>
   );
 };

diff --git a/src/library-authoring/collections/LibraryCollectionPage.tsx b/src/library-authoring/collections/LibraryCollectionPage.tsx
@@ -169,7 +169,7 @@ const LibraryCollectionPageInner = ({ libraryId }: { libraryId: string }) => {
             <div className="flex-grow-1" />
             <SearchSortWidget />
           </div>
-          <LibraryCollectionComponents libraryId={libraryId} />
+          <LibraryCollectionComponents />
         </Container>
         <StudioFooter />
       </div>

diff --git a/src/library-authoring/components/LibraryComponents.test.tsx b/src/library-authoring/components/LibraryComponents.test.tsx
@@ -95,7 +95,7 @@ const RootWrapper = (props) => (
     <IntlProvider locale="en" messages={{}}>
       <QueryClientProvider client={queryClient}>
         <SearchContextProvider>
-          <LibraryComponents libraryId="1" {...props} />
+          <LibraryComponents {...props} />
         </SearchContextProvider>
       </QueryClientProvider>
     </IntlProvider>

diff --git a/src/library-authoring/components/LibraryComponents.tsx b/src/library-authoring/components/LibraryComponents.tsx
@@ -9,7 +9,6 @@ import { LIBRARY_SECTION_PREVIEW_LIMIT } from './LibrarySection';
 import { LibraryContext } from '../common/context';
 
 type LibraryComponentsProps = {
-  libraryId: string,
   variant: 'full' | 'preview',
 };
 
@@ -20,7 +19,7 @@ type LibraryComponentsProps = {
  *   - 'full': Show all components with Infinite scroll pagination.
  *   - 'preview': Show first 4 components without pagination.
  */
-const LibraryComponents = ({ libraryId, variant }: LibraryComponentsProps) => {
+const LibraryComponents = ({ variant }: LibraryComponentsProps) => {
   const {
     hits,
     totalHits: componentCount,