refactor: handle relative proctoring link

openedx · May 2, 2024 · 03f362a · 03f362a
1 parent 65f45f7
commit 03f362a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 5 deletions.
diff --git a/src/course-outline/card-header/CardHeader.jsx b/src/course-outline/card-header/CardHeader.jsx
@@ -61,6 +61,13 @@ const CardHeader = ({
   const [titleValue, setTitleValue] = useState(title);
   const cardHeaderRef = useRef(null);
   const [isManageTagsDrawerOpen, openManageTagsDrawer, closeManageTagsDrawer] = useToggle(false);
+  let fullProctoringExamConfigurationLink = proctoringExamConfigurationLink;
+
+  if (proctoringExamConfigurationLink && !(
+    proctoringExamConfigurationLink.indexOf('http://') === 0 || proctoringExamConfigurationLink.indexOf('https://') === 0
+  )) {
+    fullProctoringExamConfigurationLink = new URL(proctoringExamConfigurationLink, getConfig().STUDIO_BASE_URL).href;
+  }
 
   const isDisabledPublish = (status === ITEM_BADGE_STATUS.live
     || status === ITEM_BADGE_STATUS.publishedNotLive) && !hasChanges;
@@ -152,12 +159,12 @@ const CardHeader = ({
               iconAs={Icon}
             />
             <Dropdown.Menu>
-              {isSequential && proctoringExamConfigurationLink && (
+              {isSequential && fullProctoringExamConfigurationLink && (
                 <Dropdown.Item
                   as={Hyperlink}
                   target="_blank"
-                  destination={proctoringExamConfigurationLink}
-                  href={proctoringExamConfigurationLink}
+                  destination={fullProctoringExamConfigurationLink}
+                  href={fullProctoringExamConfigurationLink}
                   externalLinkTitle={intl.formatMessage(messages.proctoringLinkTooltip)}
                 >
                   {intl.formatMessage(messages.menuProctoringLinkText)}

diff --git a/src/course-outline/card-header/CardHeader.test.jsx b/src/course-outline/card-header/CardHeader.test.jsx
@@ -265,14 +265,31 @@ describe('<CardHeader />', () => {
   it('check if proctoringExamConfigurationLink is visible', async () => {
     const { findByText, findByTestId } = renderComponent({
       ...cardHeaderProps,
-      proctoringExamConfigurationLink: 'https://localhost:8000/',
+      proctoringExamConfigurationLink: 'proctoringlink',
       isSequential: true,
     });
 
     const menuButton = await findByTestId('subsection-card-header__menu-button');
     await act(async () => fireEvent.click(menuButton));
 
-    expect(await findByText(messages.menuProctoringLinkText.defaultMessage)).toBeInTheDocument();
+    const element = await findByText(messages.menuProctoringLinkText.defaultMessage);
+    expect(element).toBeInTheDocument();
+    expect(element.getAttribute('href')).toBe(`${getConfig().STUDIO_BASE_URL}/proctoringlink`);
+  });
+
+  it('check if proctoringExamConfigurationLink is absolute', async () => {
+    const { findByText, findByTestId } = renderComponent({
+      ...cardHeaderProps,
+      proctoringExamConfigurationLink: 'http://localhost:9000/proctoringlink',
+      isSequential: true,
+    });
+
+    const menuButton = await findByTestId('subsection-card-header__menu-button');
+    await act(async () => fireEvent.click(menuButton));
+
+    const element = await findByText(messages.menuProctoringLinkText.defaultMessage);
+    expect(element).toBeInTheDocument();
+    expect(element.getAttribute('href')).toBe('http://localhost:9000/proctoringlink');
   });
 
   it('check if discussion enabled badge is visible', async () => {