Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: analytics v2 fixes #1347

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: analytics v2 fixes #1347

merged 1 commit into from
Nov 13, 2024

Conversation

muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Nov 13, 2024

Description:

  • Sorted the audit and certificate enrollment types so that audit data always comes first.
  • Use the courseKey instead of courseTitle in top 10 courses charts so that we can compare the charts between V1 and V2. This change is needed because we are not courseTitle in V1 and this makes chart comparison difficult and add ambiguity.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (dd5c77d) to head (024732e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1347   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         600      600           
  Lines       13215    13215           
  Branches     2740     2740           
=======================================
  Hits        11307    11307           
  Misses       1843     1843           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include a short description of the issues addressed in this PR?

@muhammad-ammar muhammad-ammar merged commit 2306588 into master Nov 13, 2024
6 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/analytics-v2-fixes branch November 13, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants