Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add people management page + zero state #1322

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 27, 2024

Screenshot 2024-09-27 at 9 51 00 AM
Screenshot 2024-09-27 at 9 51 07 AM

To test:

  • In EnterpriseAppRoutes.jsx change line 120 to {enterpriseAppPage === ROUTE_NAMES.peopleManagement && (
  • in Sidebar/index.jsx, comment out line 158 (the hidden property of the People Management page)
  • run npm run start:stage and ensure you can see the People Management tab in the sidebar
    Jira | Figma

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested a review from a team September 27, 2024 19:33
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.63%. Comparing base (e3b1452) to head (19a5915).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/components/EnterpriseApp/EnterpriseAppRoutes.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
+ Coverage   85.62%   85.63%   +0.01%     
==========================================
  Files         576      577       +1     
  Lines       12700    12719      +19     
  Branches     2691     2705      +14     
==========================================
+ Hits        10874    10892      +18     
  Misses       1766     1766              
- Partials       60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far! I have just a few comments/questions.

src/components/EnterpriseApp/index.jsx Outdated Show resolved Hide resolved
src/components/EnterpriseApp/index.jsx Outdated Show resolved Hide resolved
src/components/EnterpriseApp/index.jsx Outdated Show resolved Hide resolved
src/components/EnterpriseApp/index.jsx Outdated Show resolved Hide resolved
src/components/PeopleManagement/index.jsx Outdated Show resolved Hide resolved
src/components/PeopleManagement/index.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make a few changes to match the updates in figma, but otherwise looks good so far!

@kiram15 kiram15 merged commit e0288ab into master Oct 3, 2024
4 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9463 branch October 3, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants