-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add people management page + zero state #1322
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
==========================================
+ Coverage 85.62% 85.63% +0.01%
==========================================
Files 576 577 +1
Lines 12700 12719 +19
Branches 2691 2705 +14
==========================================
+ Hits 10874 10892 +18
Misses 1766 1766
- Partials 60 61 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far! I have just a few comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make a few changes to match the updates in figma, but otherwise looks good so far!
b0a3a67
to
a2f86fa
Compare
To test:
{enterpriseAppPage === ROUTE_NAMES.peopleManagement && (
npm run start:stage
and ensure you can see the People Management tab in the sidebarJira | Figma
For all changes
Only if submitting a visual change