Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persist SSO Config 'authorized' checkbox state #1121

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket
Utilizing changes made in openedx/edx-enterprise#1951

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b990fec) 85.12% compared to head (7756622) 85.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         482      482           
  Lines       10154    10154           
  Branches     2133     2133           
=======================================
  Hits         8644     8644           
  Misses       1469     1469           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marlonkeating marlonkeating changed the title feat: Persist SSO Config 'authorized' checkbox statt feat: Persist SSO Config 'authorized' checkbox state Dec 6, 2023
@marlonkeating marlonkeating merged commit 4f33500 into master Dec 6, 2023
6 checks passed
@marlonkeating marlonkeating deleted the mkeating/ENT-7990 branch December 6, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants