fix: use multiple analytics card messages #1067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous use of `adminPortal.analyticsCardText`was fully dynamic, and resulted in "Messages must be statically evaluate-able for extraction." errors when running `make extract_translations`. This splits the message up into separately translatable messages, and updates the logic for displaying them accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 83.60% 83.62% +0.01%
==========================================
Files 443 443
Lines 9444 9445 +1
Branches 1968 1969 +1
==========================================
+ Hits 7896 7898 +2
Misses 1505 1505
+ Partials 43 42 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous use of
adminPortal.analyticsCardTextwas fully dynamic, and resulted in "Messages must be statically evaluate-able for extraction." errors when runningmake extract_translations. This splits the message up into separately translatable messages, and updates the logic for displaying them accordingly.For all changes
Only if submitting a visual change