Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add has_dismissed field #366

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: add has_dismissed field #366

wants to merge 1 commit into from

Conversation

katrinan029
Copy link
Contributor

No description provided.

@iloveagent57
Copy link
Contributor

I was chatting with Adam about this offline, here's a proposal for a slightly different approach:

  1. IMO, I think has_dismissed would be better modeled as a new type of LearnerContentAssignmentAction rather than a field on the assignment itself, with a new action type like learner_acknowledged_cancellation.
  2. You could have the credits-available view filter out cancelled assignments based on the presence of such an action.
  3. We would then add a new view to the LearnerContentAssignmentViewSet with the DRF action() decorator, like def acknowledge_cancellation(...). That view would add the ack'd cancellation action for the assignment.

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants