Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read toml using path not file content #465

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

zubairshakoorarbisoft
Copy link
Contributor

@zubairshakoorarbisoft zubairshakoorarbisoft commented Dec 22, 2023

toml.load function read toml file and converts into dict, it take both content and file path and decides. But In our case we were passing file content but due to some reasons in the content it was considering it a file so now we are reading it using file name so that load function always use path to read file, I tested it on local.

Error build: https://github.com/edx/repo-health-data/actions/runs/7298483488/job/19889543897#step:10:783

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f5061df) 75.03% compared to head (646c688) 75.08%.

Files Patch % Lines
repo_health/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   75.03%   75.08%   +0.04%     
==========================================
  Files          26       26              
  Lines        1514     1513       -1     
==========================================
  Hits         1136     1136              
+ Misses        378      377       -1     
Flag Coverage Δ
unittests 75.08% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UsamaSadiq UsamaSadiq merged commit 82580db into master Dec 22, 2023
5 of 6 checks passed
@UsamaSadiq UsamaSadiq deleted the zshkoor/toml-reading-fix branch December 22, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants