fix: Respect the authsource kwarg for MongoDB connections #35239
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @blarghmatey! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@blarghmatey Tests are failing. |
blarghmatey
force-pushed
the
tm/pymongo_authsource_fix
branch
4 times, most recently
from
d950f21
to
90f6073
Compare
|
@mumarkhan999 all of the checks are passing now. |
The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The `authSource` parameter was being hard-coded to use the database being connected to. In Mongo the `admin` db is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures. This restores the behavior of allowing for the lowercased `authsource` kwarg to be used for the `authSource` connection parameter, while otherwise respecting the operator's configuration parameters.
blarghmatey
force-pushed
the
tm/pymongo_authsource_fix
branch
from
02ef115
to
af8cf38
Compare
The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The `authSource` parameter was being hard-coded to use the database being connected to. In Mongo the `admin` db is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures. This restores the behavior of allowing for the lowercased `authsource` kwarg to be used for the `authSource` connection parameter, while otherwise respecting the operator's configuration parameters.
blarghmatey
force-pushed
the
tm/pymongo_authsource_fix
branch
from
af8cf38
to
395c2dc
Compare
|
@mumarkhan999 it looks like all of your comments have been addressed. Let me know if you run into any other issues while testing. |
|
@blarghmatey 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
) * fix: Respect the authsource kwarg for MongoDB connections The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The `authSource` parameter was being hard-coded to use the database being connected to. In Mongo the `admin` db is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures. This restores the behavior of allowing for the lowercased `authsource` kwarg to be used for the `authSource` connection parameter, while otherwise respecting the operator's configuration parameters. * fix: Respect the authsource kwarg for MongoDB connections The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The `authSource` parameter was being hard-coded to use the database being connected to. In Mongo the `admin` db is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures. This restores the behavior of allowing for the lowercased `authsource` kwarg to be used for the `authSource` connection parameter, while otherwise respecting the operator's configuration parameters.
Description
The changes for upgrading to PyMongo 4.4 introduced an authentication bug in Mongo connections. The
authSourceparameter was being hard-coded to use the database being connected to. In Mongo theadmindb is typically the source of authentication, so unless the user was explicitly created in the target db then any attempts to connect would result in authentication failures.This restores the behavior of allowing for the lowercased
authsourcekwarg to be used for theauthSourceconnection parameter, while otherwise respecting the operator's configuration parameters.Supporting information
This addresses an error introduced by #35179
Testing instructions
To test this change requires a MongoDB instance that is using a modulestore database name that is different than
adminand does not contain the user that is authenticating (which is a fairly common scenario). Specifying eitherauthsourceorauthSourcein the configuration should allow the connection to be made without error.Deadline
ASAP, as the master branch is broken for typical MongoDB installations.