Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add waffle flag for beta testing new problem editor parser #35184

Merged

Conversation

KristinAoki
Copy link
Member

@KristinAoki KristinAoki commented Jul 25, 2024

Description

Since releasing the react based problem editor, there have been various bugs that come from the OLX parser not catching all the nuanced tags. Currently the default experience for the editor is the visual (TinyMCE) editor. The problem is navigated to the advanced editor if it uses an advanced problem tags, has multiple questions in a problem, and a non-default tag or attribute is found. This approach requires updates to the problem editor parser each time a new tag or attribute is brought to the developers attention so that the content that it is referencing is not lost by accidentally rendering the wrong editor. To simply the need for constant updates for new tags or attributes, the new OLX parser will have a specific list of tags and attributes that are allowed in the visual editor. The array of supported tags and attributes will generated from the Read The Docs site. If there is a tag or attribute that is not in the supported list the advanced problem editor will be displayed to ensure that no OLX was lost when between the last save and opening of the problem.

To confirm the new parser is an improvement, we need a waffle flag that will control which users will have the problem editor with the new parser or the current parser. This change impact "Authors" and "Developers".

Supporting information

JIRA Tickets: TNL-11667 🔒 and TNL-11694 🔒

Testing instructions

  1. Open a course
  2. Create a new problem block
  3. Confirm that the problem can be opened and edited
  4. Save the problem
  5. Reopen the problem
  6. Confirm that the problem can be opened and edited

Deadline

None

Other information

frontend-lib-content-components PR #496 is dependent on this change

Copy link
Contributor

@rayzhou-bit rayzhou-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code should be removed but otherwise it lgtm!

@KristinAoki KristinAoki merged commit 8d0ada5 into master Jul 26, 2024
49 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/add-beta-waffle-flag-for-problem-editor-parser branch July 26, 2024 16:00
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants