Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FC-0059] feat: New fields in library details API view #35091

Merged
merged 11 commits into from
Aug 1, 2024
Merged

[FC-0059] feat: New fields in library details API view #35091

merged 11 commits into from
Aug 1, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jul 5, 2024 •
edited
Loading

Description

  1. This adds the following fields in the library details API view:
  • last_draft_created
  • last_draft_created_by
  • published_by
  • created
  • updated
  1. Delete collection_uuid from serializers

Supporting information

Testing instructions

Use this branch and follow the testing instructions on openedx/frontend-app-authoring#1138

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 5, 2024 •
edited
Loading

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 5, 2024
@ChrisChV ChrisChV marked this pull request as draft July 5, 2024 09:25
@ChrisChV ChrisChV changed the title feat: Add created and updated field to library details api response [FC-0059] feat: Add created and updated field to library details api response Jul 5, 2024
@ChrisChV
Merge branch 'master' into chris/FAL-3760-update-content-libraries-api
42ef321
@ChrisChV
feat: New updates to allow return new fields of library in API view
94e1832 
- create_library_block updated to allow save user that creates the block
- publish_changes updated to allow save user that publish the changes.
- published_by, last_draft_created and last_draft_created_by added to get_library response
@ChrisChV
style: Lint on code
8bf1ffd
@ChrisChV ChrisChV changed the title [FC-0059] feat: Add created and updated field to library details api response [FC-0059] feat: New fields in library details API view Jul 25, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 30, 2024
@ChrisChV ChrisChV marked this pull request as ready for review July 31, 2024 16:30
@ChrisChV ChrisChV mentioned this pull request Jul 31, 2024
Merged
rpenido
rpenido approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work @ChrisChV!

uwsgi.ini Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this.

bradenmacdonald
bradenmacdonald approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, conditional approval if you remove uwsgi.ini

@ChrisChV
Copy link
Contributor Author

ChrisChV commented Aug 1, 2024

@bradenmacdonald I deleted uwsgi.ini: ba201ad

@bradenmacdonald bradenmacdonald merged commit 2788f2b into openedx:master Aug 1, 2024
49 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/FAL-3760-update-content-libraries-api branch August 1, 2024 18:50
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

@rpenido rpenido rpenido approved these changes

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChrisChV @openedx-webhooks @edx-pipeline-bot @rpenido @bradenmacdonald @mphilbrick211