feat: implicitCount added to content search index

[ChrisChV]

Description

Adds implicit_count to content search index.

Supporting information

• This is used to show tag count in library components card: Library Components Tab frontend-app-authoring#1037
• Internal ticket: FAL-3757

Testing instructions

• Run taxonomy-sample-data script.
• Make sure you have meilisearch setup locally, follow the setup instructions here https://github.com/open-craft/tutor-contrib-meilisearch.
• Run tutor dev run cms bash and ./manage.py cms reindex_studio --experimental.
• Access http://meilisearch.local.edly.io:7700/ and check if the created documents have the tags.implicit_count field

[openedx-webhooks]

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[rpenido]

LGTM 👍 @ChrisChV ! Good work.

• I tested this following the test instructions
• I read through the code and considered the security, stability and performance implications of the changes.
• Includes tests for bugfixes and/or features added.

[bradenmacdonald]

Can't you just compute this from the response? The implicit_count should always be equal to tags.level0.length + tags.level1.length + tags.level2.length + tags.level3.length. So do we really need to store it in the index as a separate field?

[ChrisChV]

Can't you just compute this from the response? The implicit_count should always be equal to tags.level0.length + tags.level1.length + tags.level2.length + tags.level3.length. So do we really need to store it in the index as a separate field?

Yes, it was one of my options, but I think that adding to the index would be the easiest way to obtain tag count without having to calculate it in all the responses that need the count tag. If you need the count tags it's easy to get it from the index. What do you think?

[bradenmacdonald]

I think it's so simple to calculate that we might as well just calculate it ourselves when we need it. But if we need to sort by the tag count or filter by the tag count, then we definitely need to add to the index. If we don't need that, I wouldn't bother personally.

[ChrisChV]

I think it's so simple to calculate that we might as well just calculate it ourselves when we need it. But if we need to sort by the tag count or filter by the tag count, then we definitely need to add to the index. If we don't need that, I wouldn't bother personally.

Make sense. Updated: open-craft/frontend-app-authoring@0843a1e

[ChrisChV]

This index change is not longe necessary for now.

[openedx-webhooks]

@ChrisChV Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.