test: always run aggregate unit test check #34903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a shard of unit-tests.yml fails, we want the `success` job to be maked "Failed" (not "Skipped"). That's because "Failed" blocks the PR from merging, whereas "Skipped" does not. This change ensures that `success` always runs to completion rather than being cancelled as soon as a unit test shard fails or is cancelled. From https://github.com/marketplace/actions/alls-green#options: > Important: For this to work properly, it is a must to have the job always run, > otherwise GitHub will make it skipped when any of the dependencies fail. In > some contexts, skipped is interpreted as success which may lead to undersired, > unobvious and even dangerous (as in security breach "dangerous") side-effects. Closes #34789
feanil
approved these changes
Jun 3, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a shard of unit-tests.yml fails, we want the
successjob to bemaked "Failed" (not "Skipped"). That's because "Failed" blocks the PR from merging, whereas "Skipped" does not. This change ensures thatsuccessalways runs to completion rather than being cancelled as soon as a unit test shard fails or is cancelled.From https://github.com/marketplace/actions/alls-green#options:
Closes #34789