Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update to use Learning Core's new public API #34815

Merged
merged 1 commit into from
May 21, 2024

Conversation

ormsbee
Copy link
Contributor

@ormsbee ormsbee commented May 17, 2024

Depends on openedx/openedx-learning#184

This is a disruptive, backwards-incompatible change as far as code is concerned, but involves no database changes.

  • We now import from the consolidated public API module openedx_learning.api.authoring instead of individual apps.
  • Models come from openedx_learning.api.authoring_models.
  • Import linting is added to enforce that openedx_learning.apps is intended to be private.

@ormsbee ormsbee marked this pull request as draft May 17, 2024 04:17
@ormsbee ormsbee force-pushed the learning-core-api-refactor branch 2 times, most recently from d18f1b8 to 693849b Compare May 21, 2024 18:55
@ormsbee ormsbee marked this pull request as ready for review May 21, 2024 18:55
This also bumps our openedx-learning dependency to 0.10.0 (the first
version with the new openedx_learning.api package).
@ormsbee ormsbee force-pushed the learning-core-api-refactor branch from 693849b to e7402fc Compare May 21, 2024 19:15
@ormsbee ormsbee merged commit be03938 into openedx:master May 21, 2024
48 checks passed
@ormsbee ormsbee deleted the learning-core-api-refactor branch May 21, 2024 20:06
@bradenmacdonald
Copy link
Contributor

Nice!

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants