Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Transifex calls for FC-0012 - OEP-58 #34355

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Mar 12, 2024

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

  • Removes direct use of tx pull and tx push commands
  • Remove source and language translations from the repositories, hence no .po or .mo files will be committed into the repos
  • Remove Transifex related Makefile targets and configuration files
  • Remove all unneeded mentions of Transifex
  • Clean up paver i18n_* obsolete commands

TODO

  • Test locally on devstack before pull_translations
Screenshot for Arabic language without translations

image

  • Test locally on devstack after pull_translations
Screenshot for Arabic with translations

image

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 12, 2024

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi marked this pull request as ready for review March 14, 2024 08:45
@OmarIthawi
Copy link
Member Author

@timmc-edx this pull request is ready.

cc: @brian-smith-tcril

@timmc-edx timmc-edx merged commit a10fce3 into openedx:master Mar 14, 2024
67 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

else
pull_translations: ## pull translations via atlas
# Clean up the existing translations
git clean -fdX conf/locale conf/plugins-locale */static/js/i18n/ */static/js/xblock.v1-i18n/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing some problems -- it deletes any virtualenv that's maintained inside the repo (.venv-3.8/ in my case) as well as the Open_edX.egg-info/ created when installing base requirements. The former causes the command to fail entirely, and the latter produces the following error:

RuntimeError: Model class openedx.core.djangoapps.content_libraries.models.ContentLibrary doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.
make[1]: *** [Makefile:52: pull_xblock_translations] Error 1

Can we use a different command? Or is this even needed at all. It seems to me that a git pull should remove the files just fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that if one of the path arguments to git clean doesn't exist and contains a globbing character (e.g. */static/js/xblock.v1-i18n/) then the command also removes some things outside of the given paths.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmc-edx sorry about that. I don't fully understand why git clean is behaving like this, so I've gone and refactored the command to be more explicit and safe:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants