-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0044] certificates API DRF #34339
feat: [FC-0044] certificates API DRF #34339
Conversation
Thanks for the pull request, @ruzniaievdm! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
b02a49a
to
2e6b656
Compare
2e6b656
to
e682381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please include in the description the complete steps, from scratch, on how to test this properly? Including how to enable the feature, how to use the waffle flags, and how to create a certificate?
e682381
to
54bb5da
Compare
@arbrandes I've updated the description with new links to the certificate configuration for the course including enabling the feature for certificate MFE page. |
98345a9
to
eb4f416
Compare
```json | ||
{ | ||
"certificate_activation_handler_url": "/certificates/activation/course-v1:org+101+101/", | ||
"certificate_web_view_url": "///certificates/course/course-v1:org+101+101?preview=honor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this url supposed to start with three forward slashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original method for this field is get_lms_link_for_certificate_web_view
here which contains return "//{certificate_web_base}/certificates/course/{course_id}?preview={mode}".format()
. Therefore I can assume that this is the real value for the certificate_web_view_url
field.
eb4f416
to
745509e
Compare
745509e
to
cfee3b1
Compare
cfee3b1
to
0c6f0bd
Compare
0c6f0bd
to
f7b61d5
Compare
@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Settings
Description
This PR addresses a need in the development of the Course Certificate Page feature within the frontend-app-course-authoring repository. The core objective is the implement of a DRF endpoint designed to render and deliver certificate data for course.
How to configure certificates:
Certificate Pages:
http://localhost:18010/certificates/{location}
.http://localhost:2001/course/{location}/certificates
.Testing API instructions:
make dev.up.lms+cms
and make checkout on this branch.http://localhost:18010/api-docs
./api/contentstore/v1/certificates/{location}
.Testing MFE instructions:
make dev.up.lms+cms+frontend-app-course-authoring
and make checkout on this branch.contentstore.new_studio_mfe.use_new_certificates_page
on thehttp://localhost:18010/admin/waffle/flag/
http://localhost:2001/course/{location}/certificates
.Related PR's:
Certificate issue
openedx/platform-roadmap#317