check ENABLE_ACCOUNT_DELETION before account deletion

[JonasBM]

Referenced issue: Allow Disable Account Deletion

ENABLE_ACCOUNT_DELETION hides the option of deletion, but the user is still able to make a request to the backend.
This PR ensures that account deletion is allowed, and if not, returns an HTTP 403 "Forbidden" response.

[openedx-webhooks]

Thanks for the pull request, @JonasBM! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[mphilbrick211]

@openedx/2u-aperture @jsnwesson Hi there! Is this something you can review for us? If so, we can address the conflicts.

[jsnwesson]

@mphilbrick211 I believe it is! I'll have our on-call engineer triage it for the team.

[deborahgu]

@mphilbrick211 I'm adding this to our queue, but is there any reason not to address the conflicts now? Obviously we can't put an approval on it one way or t'other without the conflicts addressed.

[JonasBM]

@deborahgu Hi!
I believe the conflict is the result of another PR solving the same problem, but was already merged.
If this is the case, maybe this PR should be just closed.

[mphilbrick211]

@deborahgu Hi! I believe the conflict is the result of another PR solving the same problem, but was already merged. If this is the case, maybe this PR should be just closed.

Thanks, @deborahgu and @jsnwesson! RE: the branch conflicts, we've run into situations where PR authors have to repeatedly resolve conflicts while waiting for review (this spans across all repos / teams), but if you have an ETA on when you'll be able to review, then @JonasBM can go ahead and resolve the conflicts.

[pkulkark]

@mphilbrick211 I can help review this PR as CC.

[deborahgu]

@JonasBM speculated that this is no longer needed, is that true?

[JonasBM]

@JonasBM speculated that this is no longer needed, is that true?

Yes, there is another PR already merged that solves the problem.

[JonasBM]

This seems to be no longer necessary, I will close it to avoid more work on this.

[openedx-webhooks]

@JonasBM Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.