Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[6/6] build: common/static/css/xmodule -> xmodule/static/css" #32526

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Revert "[6/6] build: common/static/css/xmodule -> xmodule/static/css" #32526

merged 1 commit into from
Jun 21, 2023

Conversation

kdmccormick
Copy link
Member

Reverts #32291, just in case.

@kdmccormick kdmccormick deleted the revert-32291-kdmccormick/xmodule-static-css branch June 21, 2023 17:24
@kdmccormick kdmccormick restored the revert-32291-kdmccormick/xmodule-static-css branch June 21, 2023 17:43
@kdmccormick kdmccormick reopened this Jun 21, 2023
@kdmccormick kdmccormick force-pushed the revert-32291-kdmccormick/xmodule-static-css branch from 7932113 to a732396 Compare June 21, 2023 17:44
@kdmccormick kdmccormick marked this pull request as ready for review June 21, 2023 17:49
@kdmccormick kdmccormick mentioned this pull request Jun 21, 2023
Merged
@kdmccormick
Copy link
Member Author

@rayzhou-bit could you review?

I have some ideas of what could be wrong and how to fix it, but I think it'd be safest just to revert for now.

@kdmccormick kdmccormick merged commit a903230 into master Jun 21, 2023
@kdmccormick kdmccormick deleted the revert-32291-kdmccormick/xmodule-static-css branch June 21, 2023 18:23
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@kenclary kenclary mentioned this pull request Jun 29, 2023
Merged
aht007 pushed a commit that referenced this pull request Jul 4, 2023
@kdmccormick @aht007
revert build: common/static/css/xmodule -> xmodule/static/css (#32291)…
f1d5c41 
…" (#32526)

This reverts commit 5671dab.

The original PR is causing styling issues due to broken CSS references
on studio.edx.org.

See #32292 for follow-up.
@kenclary kenclary mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayzhou-bit rayzhou-bit rayzhou-bit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdmccormick @edx-pipeline-bot @rayzhou-bit