[2/6] build: remove prefixes from XModule resource copies #32287

kdmccormick · 2023-05-23T15:12:03Z

Supporting information

This is a part of a series of PRs:

Stop dynamically generating XModule SCSS #32292

The previous PR is:

[1/6] refactor: define resource paths (not contents) on XModule classes #32286

The next PR is:

[3/6] build: stop suffixing XModule SCSS with hashes #32288

Description

The xmodule_assets command copies SCSS files from
xmodule/css to common/static/xmodule/{modules|descriptors}/scss.
It renames the files to the format:

 _{INDEX}-{HASH}.scss

where an XModule's first SCSS resource will have INDEX==0,
the next will have INDEX==1, ...and that's it because no
XModule has more than two SCSS resources.

The output looks like this:

common/static/xmodule/descriptors/scss:
  _000-808fcbb4c5109c5156ae3c0c9729c8be.scss
  _000-9bdcda00f046f78be79aca7791e1d4fb.scss
  _000-d41921b4c5d45188759ef3d04fd9a78a.scss
  _001-901b985e5ea2dea2a89cce747cf4307d.scss
  _001-a10fc3e0fd6aca63426a89e75fe69c31.scss
common/static/xmodule/modules/scss:
  _000-1ad2f05db822d3176affd203d70319c0.scss
  _000-1dc4276d3849a14ea538286e97740c14.scss
  _000-29baf1ef1af89b1051362f51124abd01.scss
  _000-6bf8c2340b013d835b25df13e03b8d33.scss
  _000-8b6bb50b058d34efefa40107307a32c6.scss
  _000-958d6ef6baa09be94bccaf488861c8e5.scss
  _000-a3c2cdf2141d24a76be9afa56f237c29.scss
  _000-b80300e1a5f290f6a850e35874068427.scss
  _001-482ebc752ab6e41946651ceb0f3e7f55.scss

These indexes serve no purpose. Reading the comments
and git-blame in xmodule/static_content.py, one can glean
that the indexes might have been intended to enforce
dependency relationships between the assets, but
this is unnecessary, because the ordering of the copied
SCSS is already preserved by the order which they're
included into the {BLOCK_NAME}{Studio|Preivew}.{HASH}.scss
SCSS entrypoint files. I have to assume that this is an
unnecessary relic from the time when the XModule system
was more heavily utilized, rather than just a legacy corner
of the XBlock framework as it is today.

So, we remove the indexes, which lets us simplify the logic
of xmodule/static_content.py. This is a minor refactoring, but it'll
make it easier for the next steps on our way to deleting
xmodule/static_content.py entirely. The new output looks like this:

common/static/xmodule/descriptors/scss:
  _808fcbb4c5109c5156ae3c0c9729c8be.scss
  _901b985e5ea2dea2a89cce747cf4307d.scss
  _9bdcda00f046f78be79aca7791e1d4fb.scss
  _a10fc3e0fd6aca63426a89e75fe69c31.scss
  _d41921b4c5d45188759ef3d04fd9a78a.scss
common/static/xmodule/modules/scss:
  _1ad2f05db822d3176affd203d70319c0.scss
  _1dc4276d3849a14ea538286e97740c14.scss
  _29baf1ef1af89b1051362f51124abd01.scss
  _482ebc752ab6e41946651ceb0f3e7f55.scss
  _6bf8c2340b013d835b25df13e03b8d33.scss
  _8b6bb50b058d34efefa40107307a32c6.scss
  _958d6ef6baa09be94bccaf488861c8e5.scss
  _a3c2cdf2141d24a76be9afa56f237c29.scss
  _b80300e1a5f290f6a850e35874068427.scss

Testing Instructions

Build the Tutor openedx image with this branch
Browse the demo course in the Studio outline editor
Browse the demo course in Learning MFE

Deadline

Medium-high urgency, as this is in the critical path to a long line of DevX improvement PRs.

Similar to openedx#32287, this change removes another unnecessary step from the `xmodule_assets` script. The script, which generates XModule SCSS "entrypoint" files (synthesizing one or more "source" SCSS resources), was appending MD5 hashes to each SCSS entrypoint filename: common/static/xmodule/descriptors/scss: AboutBlockStudio.768623f4d8d73dfb637fc94583adb990.scss AnnotatableBlockStudio.be69909d83985d31e206fad272906958.scss ConditionalBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss CourseInfoBlockStudio.768623f4d8d73dfb637fc94583adb990.scss CustomTagBlockStudio.be69909d83985d31e206fad272906958.scss HtmlBlockStudio.768623f4d8d73dfb637fc94583adb990.scss LibraryContentBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss LTIBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss PollBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss ProblemBlockStudio.5893b30426f88e14712556c6c4342f23.scss SequenceBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss SplitTestBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss StaticTabBlockStudio.768623f4d8d73dfb637fc94583adb990.scss VideoBlockStudio.e4a6920a875dfb91eb65ee7e6dad7e2e.scss WordCloudBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss common/static/xmodule/modules/scss: AboutBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss AnnotatableBlockPreview.7e95b106aa0a61824f4290da1374960d.scss ConditionalBlockPreview.d41d8cd98f00b204e9800998ecf8427e.scss CourseInfoBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss CustomTagBlockPreview.d41d8cd98f00b204e9800998ecf8427e.scss HtmlBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss LibraryContentBlockPreview.d41d8cd98f00b204e9800998ecf8427e.scss LTIBlockPreview.a763928b2c415251720f8634b8daee59.scss PollBlockPreview.39730e54c1eebbafd18a82fbb09c1e37.scss ProblemBlockPreview.70b905ac161108a0a03c639232450aaa.scss SequenceBlockPreview.e2336fa64ba495fa7c0f4f838d20ad8c.scss SplitTestBlockPreview.d41d8cd98f00b204e9800998ecf8427e.scss StaticTabBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss VideoBlockPreview.b2de5e1c4da8cba16ce1c4bdeab50f9e.scss WordCloudBlockPreview.7b899a56a70d29c58cf14b7e1888a0ec.scss It's unclear why these MD5 hashes needed to be appended. A comment in xmodule/static_content.py hints that it might have something to do with de-duplication, but that doesn't make any sense, because each XModule has exactly two SCSS entrypoint files (one for studio_view and one for other student/author_views) and none of those entrypoint files can possibly be shared between XModules. Soon, as part of deleting the `xmodule_assets` script, we would like to just check these SCSS files into version control rather than generating them. In order to do that, we will need to drop the hashes. So, in the interest of isolating changes in hard-to-test subsystems, this change simply drops the MD5 hashes from the generated SCSS filenames. The new output looks like this: common/static/xmodule/descriptors: AboutBlockStudio.scss AnnotatableBlockStudio.scss ConditionalBlockStudio.scss CourseInfoBlockStudio.scss CustomTagBlockStudio.scss HtmlBlockStudio.scss LibraryContentBlockStudio.scss LTIBlockStudio.scss PollBlockStudio.scss ProblemBlockStudio.scss SequenceBlockStudio.scss SplitTestBlockStudio.scss StaticTabBlockStudio.scss VideoBlockStudio.scss WordCloudBlockStudio.scss common/static/xmodule/modules: AboutBlockPreview.scss AnnotatableBlockPreview.scss ConditionalBlockPreview.scss CourseInfoBlockPreview.scss CustomTagBlockPreview.scss HtmlBlockPreview.scss LibraryContentBlockPreview.scss LTIBlockPreview.scss PollBlockPreview.scss ProblemBlockPreview.scss SequenceBlockPreview.scss SplitTestBlockPreview.scss StaticTabBlockPreview.scss VideoBlockPreview.scss WordCloudBlockPreview.scss Part of: openedx#31624

andrey-canon

@kdmccormick I left two suggestions, I think one of them is important since that avoid to generate unnecessary files

andrey-canon · 2023-06-02T15:27:33Z

xmodule/static_content.py

+                hash=hashlib.md5(fragment).hexdigest(),
+                type='scss')
+            # Prepend _ so that sass just includes the files into a single file
+            filename = '_' + fragment_name


This suggestion doesn't make a big difference in performance or readability but I always suggest to use f-strings, anyways this is part of the original code

@andrey-canon I agree that f-strings are better. In this particular case I will leave it as-is because PR 4/6 will delete this block entirely and changing it now would make the rebase more difficult.

xmodule/static_content.py

The `xmodule_assets` command copies SCSS files from xmodule/css to common/static/xmodule/{modules|descriptors}/scss. It renames the files to the format: _{INDEX}-{HASH}.scss where an XModule's first SCSS resource will have INDEX==0, the next will have INDEX==1, ...and that's it because no XModule has more than two SCSS resources. The output looks like this: common/static/xmodule/descriptors/scss: _000-808fcbb4c5109c5156ae3c0c9729c8be.scss _000-9bdcda00f046f78be79aca7791e1d4fb.scss _000-d41921b4c5d45188759ef3d04fd9a78a.scss _001-901b985e5ea2dea2a89cce747cf4307d.scss _001-a10fc3e0fd6aca63426a89e75fe69c31.scss common/static/xmodule/modules/scss: _000-1ad2f05db822d3176affd203d70319c0.scss _000-1dc4276d3849a14ea538286e97740c14.scss _000-29baf1ef1af89b1051362f51124abd01.scss _000-6bf8c2340b013d835b25df13e03b8d33.scss _000-8b6bb50b058d34efefa40107307a32c6.scss _000-958d6ef6baa09be94bccaf488861c8e5.scss _000-a3c2cdf2141d24a76be9afa56f237c29.scss _000-b80300e1a5f290f6a850e35874068427.scss _001-482ebc752ab6e41946651ceb0f3e7f55.scss These indexes serve no purpose. Reading the comments and git-blame in xmodule/static_content.py, one can glean that the indexes might have been intended to enforce dependency relationships between the assets, but this is unnecessary, because the ordering of the copied SCSS is *already preserved* by the order which they're included into the `{BLOCK_NAME}{Studio|Preivew}.{HASH}.scss` SCSS entrypoint files. I have to assume that this is an unnecessary relic from the time when the XModule system was more heavily utilized, rather than just a legacy corner of the XBlock framework as it is today. So, we remove the indexes, which lets us simplify the logic of xmodule/static_content.py. This is a minor refactoring, but it'll make it easier for the next steps on our way to deleting xmodule/static_content.py entirely. The new output looks like this: common/static/xmodule/descriptors/scss: _808fcbb4c5109c5156ae3c0c9729c8be.scss _901b985e5ea2dea2a89cce747cf4307d.scss _9bdcda00f046f78be79aca7791e1d4fb.scss _a10fc3e0fd6aca63426a89e75fe69c31.scss _d41921b4c5d45188759ef3d04fd9a78a.scss common/static/xmodule/modules/scss: _1ad2f05db822d3176affd203d70319c0.scss _1dc4276d3849a14ea538286e97740c14.scss _29baf1ef1af89b1051362f51124abd01.scss _482ebc752ab6e41946651ceb0f3e7f55.scss _6bf8c2340b013d835b25df13e03b8d33.scss _8b6bb50b058d34efefa40107307a32c6.scss _958d6ef6baa09be94bccaf488861c8e5.scss _a3c2cdf2141d24a76be9afa56f237c29.scss _b80300e1a5f290f6a850e35874068427.scss Part of: openedx#31624

kdmccormick · 2023-06-02T18:34:21Z

Thanks for your review @andrey-canon. Ready for another look.

This reverts commit 585b965.

edx-pipeline-bot · 2023-06-05T14:19:46Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-06-05T14:39:20Z

EdX Release Notice: This PR has been deployed to the production environment.

edx-pipeline-bot · 2023-06-05T14:39:20Z

EdX Release Notice: This PR has been deployed to the production environment.

Similar to openedx#32287, this change removes another unnecessary step from the `xmodule_assets` script. The script, which generates XModule SCSS "entrypoint" files (synthesizing one or more "source" SCSS resources), was appending MD5 hashes to each SCSS entrypoint filename: common/static/xmodule/descriptors/scss: AboutBlockStudio.768623f4d8d73dfb637fc94583adb990.scss ... WordCloudBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss common/static/xmodule/modules/scss: AboutBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss ... WordCloudBlockPreview.7b899a56a70d29c58cf14b7e1888a0ec.scss It's unclear why these MD5 hashes needed to be appended. A comment in xmodule/static_content.py hints that it might have something to do with de-duplication, but that doesn't make any sense, because each XModule has exactly two SCSS entrypoint files (one for studio_view and one for other student/author_views) and none of those entrypoint files can possibly be shared between XModules. Soon, as part of deleting the `xmodule_assets` script, we would like to just check these SCSS files into version control rather than generating them. In order to do that, we will need to drop the hashes. This commit does that. The new output looks like this: common/static/xmodule/descriptors: AboutBlockStudio.scss ... WordCloudBlockStudio.scss common/static/xmodule/modules: AboutBlockPreview.scss ... WordCloudBlockPreview.scss Part of: openedx#32292

Similar to #32287, this change removes another unnecessary step from the `xmodule_assets` script. The script, which generates XModule SCSS "entrypoint" files (synthesizing one or more "source" SCSS resources), was appending MD5 hashes to each SCSS entrypoint filename: common/static/xmodule/descriptors/scss: AboutBlockStudio.768623f4d8d73dfb637fc94583adb990.scss ... WordCloudBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss common/static/xmodule/modules/scss: AboutBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss ... WordCloudBlockPreview.7b899a56a70d29c58cf14b7e1888a0ec.scss It's unclear why these MD5 hashes needed to be appended. A comment in xmodule/static_content.py hints that it might have something to do with de-duplication, but that doesn't make any sense, because each XModule has exactly two SCSS entrypoint files (one for studio_view and one for other student/author_views) and none of those entrypoint files can possibly be shared between XModules. Soon, as part of deleting the `xmodule_assets` script, we would like to just check these SCSS files into version control rather than generating them. In order to do that, we will need to drop the hashes. This commit does that. The new output looks like this: common/static/xmodule/descriptors: AboutBlockStudio.scss ... WordCloudBlockStudio.scss common/static/xmodule/modules: AboutBlockPreview.scss ... WordCloudBlockPreview.scss Part of: #32292

The `xmodule_assets` command copies SCSS files from xmodule/css to common/static/xmodule/{modules|descriptors}/scss. It renames the files to the format: _{INDEX}-{HASH}.scss where an XModule's first SCSS resource will have INDEX==0, the next will have INDEX==1, ...and that's it because no XModule has more than two SCSS resources. The output looks like this: common/static/xmodule/descriptors/scss: _000-808fcbb4c5109c5156ae3c0c9729c8be.scss ... _001-a10fc3e0fd6aca63426a89e75fe69c31.scss common/static/xmodule/modules/scss: _000-1ad2f05db822d3176affd203d70319c0.scss ... _001-482ebc752ab6e41946651ceb0f3e7f55.scss These indexes serve no purpose. Reading the comments and git-blame in xmodule/static_content.py, one can glean that the indexes might have been intended to enforce dependency relationships between the assets, but this is unnecessary, because the ordering of the copied SCSS is *already preserved* by the order which they're included into the `{BLOCK_NAME}{Studio|Preivew}.{HASH}.scss` SCSS entrypoint files. I have to assume that this is an unnecessary relic from the time when the XModule system was more heavily utilized, rather than just a legacy corner of the XBlock framework as it is today. So, we remove the indexes, which lets us simplify the logic of xmodule/static_content.py. This is a minor refactoring, but it'll make it easier for the next steps on our way to deleting xmodule/static_content.py entirely. The new output looks like this: common/static/xmodule/descriptors/scss: _808fcbb4c5109c5156ae3c0c9729c8be.scss ... _d41921b4c5d45188759ef3d04fd9a78a.scss common/static/xmodule/modules/scss: _1ad2f05db822d3176affd203d70319c0.scss ... _b80300e1a5f290f6a850e35874068427.scss Part of: openedx#32292

Similar to openedx#32287, this change removes another unnecessary step from the `xmodule_assets` script. The script, which generates XModule SCSS "entrypoint" files (synthesizing one or more "source" SCSS resources), was appending MD5 hashes to each SCSS entrypoint filename: common/static/xmodule/descriptors/scss: AboutBlockStudio.768623f4d8d73dfb637fc94583adb990.scss ... WordCloudBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss common/static/xmodule/modules/scss: AboutBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss ... WordCloudBlockPreview.7b899a56a70d29c58cf14b7e1888a0ec.scss It's unclear why these MD5 hashes needed to be appended. A comment in xmodule/static_content.py hints that it might have something to do with de-duplication, but that doesn't make any sense, because each XModule has exactly two SCSS entrypoint files (one for studio_view and one for other student/author_views) and none of those entrypoint files can possibly be shared between XModules. Soon, as part of deleting the `xmodule_assets` script, we would like to just check these SCSS files into version control rather than generating them. In order to do that, we will need to drop the hashes. This commit does that. The new output looks like this: common/static/xmodule/descriptors: AboutBlockStudio.scss ... WordCloudBlockStudio.scss common/static/xmodule/modules: AboutBlockPreview.scss ... WordCloudBlockPreview.scss Part of: openedx#32292

The `xmodule_assets` command copies SCSS files from xmodule/css to common/static/xmodule/{modules|descriptors}/scss. It renames the files to the format: _{INDEX}-{HASH}.scss where an XModule's first SCSS resource will have INDEX==0, the next will have INDEX==1, ...and that's it because no XModule has more than two SCSS resources. The output looks like this: common/static/xmodule/descriptors/scss: _000-808fcbb4c5109c5156ae3c0c9729c8be.scss ... _001-a10fc3e0fd6aca63426a89e75fe69c31.scss common/static/xmodule/modules/scss: _000-1ad2f05db822d3176affd203d70319c0.scss ... _001-482ebc752ab6e41946651ceb0f3e7f55.scss These indexes serve no purpose. Reading the comments and git-blame in xmodule/static_content.py, one can glean that the indexes might have been intended to enforce dependency relationships between the assets, but this is unnecessary, because the ordering of the copied SCSS is *already preserved* by the order which they're included into the `{BLOCK_NAME}{Studio|Preivew}.{HASH}.scss` SCSS entrypoint files. I have to assume that this is an unnecessary relic from the time when the XModule system was more heavily utilized, rather than just a legacy corner of the XBlock framework as it is today. So, we remove the indexes, which lets us simplify the logic of xmodule/static_content.py. This is a minor refactoring, but it'll make it easier for the next steps on our way to deleting xmodule/static_content.py entirely. The new output looks like this: common/static/xmodule/descriptors/scss: _808fcbb4c5109c5156ae3c0c9729c8be.scss ... _d41921b4c5d45188759ef3d04fd9a78a.scss common/static/xmodule/modules/scss: _1ad2f05db822d3176affd203d70319c0.scss ... _b80300e1a5f290f6a850e35874068427.scss Part of: openedx#32292

Similar to openedx#32287, this change removes another unnecessary step from the `xmodule_assets` script. The script, which generates XModule SCSS "entrypoint" files (synthesizing one or more "source" SCSS resources), was appending MD5 hashes to each SCSS entrypoint filename: common/static/xmodule/descriptors/scss: AboutBlockStudio.768623f4d8d73dfb637fc94583adb990.scss ... WordCloudBlockStudio.d41d8cd98f00b204e9800998ecf8427e.scss common/static/xmodule/modules/scss: AboutBlockPreview.05a6cbd5c10100a245fa2cbf151b9770.scss ... WordCloudBlockPreview.7b899a56a70d29c58cf14b7e1888a0ec.scss It's unclear why these MD5 hashes needed to be appended. A comment in xmodule/static_content.py hints that it might have something to do with de-duplication, but that doesn't make any sense, because each XModule has exactly two SCSS entrypoint files (one for studio_view and one for other student/author_views) and none of those entrypoint files can possibly be shared between XModules. Soon, as part of deleting the `xmodule_assets` script, we would like to just check these SCSS files into version control rather than generating them. In order to do that, we will need to drop the hashes. This commit does that. The new output looks like this: common/static/xmodule/descriptors: AboutBlockStudio.scss ... WordCloudBlockStudio.scss common/static/xmodule/modules: AboutBlockPreview.scss ... WordCloudBlockPreview.scss Part of: openedx#32292

This reverts commit 585b965.

This was referenced May 23, 2023

[1/6] refactor: define resource paths (not contents) on XModule classes #32286

Merged

Remove special XModule asset handling #31624

Closed

kdmccormick mentioned this pull request May 23, 2023

[3/6] build: stop suffixing XModule SCSS with hashes #32288

Merged

kdmccormick changed the title ~~build: remove prefixes from XModule resource copies~~ [2] build: remove prefixes from XModule resource copies May 23, 2023

kdmccormick changed the title ~~[2] build: remove prefixes from XModule resource copies~~ [2/6] build: remove prefixes from XModule resource copies May 23, 2023

kdmccormick mentioned this pull request May 23, 2023

Stop dynamically generating XModule SCSS #32292

Closed

kdmccormick force-pushed the kdmccormick/xmodule-resource-indexes branch 2 times, most recently from 6183036 to 8534c8a Compare May 31, 2023 15:56

kdmccormick marked this pull request as ready for review June 2, 2023 13:06

andrey-canon reviewed Jun 2, 2023

View reviewed changes

kdmccormick force-pushed the kdmccormick/xmodule-resource-indexes branch from 8534c8a to b9b230b Compare June 2, 2023 18:07

kdmccormick force-pushed the kdmccormick/xmodule-resource-indexes branch from b9b230b to 2519488 Compare June 2, 2023 18:29

feanil approved these changes Jun 2, 2023

View reviewed changes

andrey-canon approved these changes Jun 2, 2023

View reviewed changes

kdmccormick merged commit 585b965 into openedx:master Jun 5, 2023

kdmccormick deleted the kdmccormick/xmodule-resource-indexes branch June 5, 2023 13:11

kdmccormick added a commit that referenced this pull request Jun 5, 2023

Revert "build: remove prefixes from XModule resource copies (#32287)"

58ff67b

This reverts commit 585b965.

kdmccormick mentioned this pull request Jun 5, 2023

Revert "[2/6] build: remove prefixes from XModule resource copies" #32366

Closed

NawfalAhmed added a commit that referenced this pull request Jun 14, 2023

Revert "build: remove prefixes from XModule resource copies (#32287)"

717182c

This reverts commit 585b965.

kenclary mentioned this pull request Jun 29, 2023

feat: basic get/post endpoint for v2 xblocks. TNL-10873 #32600

Merged

kenclary mentioned this pull request Aug 4, 2023

fix: fix mako runtime bug with studio_view. TNL-10912 #32912

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2/6] build: remove prefixes from XModule resource copies #32287

[2/6] build: remove prefixes from XModule resource copies #32287

kdmccormick commented May 23, 2023 •

edited

Loading

andrey-canon left a comment

andrey-canon Jun 2, 2023

kdmccormick Jun 2, 2023

kdmccormick commented Jun 2, 2023

edx-pipeline-bot commented Jun 5, 2023

edx-pipeline-bot commented Jun 5, 2023

edx-pipeline-bot commented Jun 5, 2023

[2/6] build: remove prefixes from XModule resource copies #32287

[2/6] build: remove prefixes from XModule resource copies #32287

Conversation

kdmccormick commented May 23, 2023 • edited Loading

Supporting information

Description

Testing Instructions

Deadline

andrey-canon left a comment

Choose a reason for hiding this comment

andrey-canon Jun 2, 2023

Choose a reason for hiding this comment

kdmccormick Jun 2, 2023

Choose a reason for hiding this comment

kdmccormick commented Jun 2, 2023

edx-pipeline-bot commented Jun 5, 2023

edx-pipeline-bot commented Jun 5, 2023

edx-pipeline-bot commented Jun 5, 2023

kdmccormick commented May 23, 2023 •

edited

Loading