build: rewrite static asset build #31912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/assets-build
branch
2 times, most recently
from
56323e0
to
700fc7b
Compare
kdmccormick
force-pushed
the
kdmccormick/assets-build
branch
11 times, most recently
from
cdb55d4
to
76d2586
Compare
kdmccormick
force-pushed
the
kdmccormick/assets-build
branch
9 times, most recently
from
7ee4080
to
b74a541
Compare
TODO description Closes openedx#31604
We want to compare the legacy and new outputs for SCSS compilation. However, there is one silly difference between the two that we can not reconcile: * The legacy build (using Python `sass.compile`) adds source comments when in dev mode, but cannot output source maps. * The new build (using CLI `sassc`) can only add source comments if it generates source maps. So, for the purposes of making our comparison pass in CI, this commit: * removes source_comments from legacy build, and * removes --sourcemap from new build. When we finally merge everything in, though, and no longer need this comparison in CI, we will just enable source maps on the new build.
kdmccormick
force-pushed
the
kdmccormick/assets-build
branch
from
75e1569
to
3c8d67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes:
Merge considerations
This PR just adds the new build implementation. It does not remove the old implementation, and it does not update anything to point at the new implementation.
Next steps
Testing instructions
Preview without running
Just check this branch, and right on your local machine, run:
and
Run the asset build and see the results in your browser
tutor dev run -m <your/edx-platform/path> assets/build.shtutor dev start -m <your/edx-platform/path>Build Tutor images
(More detailed test instructions coming soon)