-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix price discrepancy in CourseMode #26395
Fix price discrepancy in CourseMode #26395
Conversation
ffe9517
to
9550dcc
Compare
9550dcc
to
dc4a20c
Compare
dc4a20c
to
0fd03ef
Compare
Your PR has finished running tests. The following contexts failed:
|
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build. We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master. This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself:
If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal). |
Closing as this work was reprioritized. |
REV-1632.
The
min_price
column inCourseMode
table takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).This ticket:
Add new price column with type Decimal, populate the column with the same data
min_price
column has, which is now sent as a float fromLMSPublisher
request.In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce.
min_price
can receive non-int.LMSPublisher
to stop converting min_price to int.min_price
.min_price
column.