-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds LmsUrlCreationStarted filter #35142
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @jignaciopm! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
51bfa7a
to
9995472
Compare
Hi @jignaciopm! Just flagging there are some failing checks here. |
9995472
to
099e882
Compare
099e882
to
20a0c38
Compare
@jignaciopm Looks like there's a failed check. |
Hey, @jignaciopm, thanks for contributing this! Those testing instructions are a bit out of date. Could you please include them directly in the cover letter, update and simplify them? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review this in detail once you apply the changes from the openedx-filters PR and all comments there are resolved. Thank you!
context=lms_root, | ||
org=location.org, | ||
val_name='LMS_ROOT_URL', | ||
default=settings.LMS_ROOT_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the documentation and definitions we set for the framework, each filter must return the same arguments it received: https://docs.openedx.org/projects/openedx-filters/en/latest/decisions/0003-hooks-filter-tooling-pipeline.html#consequences
about_base = LmsUrlCreationStarted.run_filter( | ||
context=about_base, | ||
org=course.id.org, | ||
val_name='LMS_ROOT_URL', | ||
default=settings.LMS_ROOT_URL | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about returning the same arguments ^
Description
This PR introduces a new openedx-filters event
org.openedx.course_authoring.lms.url.creation.started.v1
. This is implemented to guaranty multi tenancy in eox-tenant in LMS_ROOT_URL from Studio to LMS, but eox-tenant is only an example would consider use.Impact by the change on:
cms/djangoapps/contentstore/views/assets.py
common/djangoapps/util/course.py
Supporting information
There are not openedx related tickets. The related PR are:
openedx/openedx-filters#200
eduNEXT/eox-tenant#179
Testing instructions
The change can be tested with testing instructions in eduNEXT/eox-tenant#179.
Deadline
"None"
Other information
Warning: Once accepted this PR, it has to be merged only after openedx/openedx-filters#77 is merged and the requirements in this PR are updated.
Settings