Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade node v18 #2231

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat: upgrade node v18 #2231

merged 5 commits into from
Oct 21, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Sep 10, 2024

Description

  • Regenerated package-lock.json with node v18.
  • Updated .nvmrc to v18
  • Updated ci workflow to use node 18
  • Pinned backbone & underscore to ensure compatibility and resolve lodash error

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (a8d0136) to head (e9fac04).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2231   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         195      195           
  Lines       21601    21601           
  Branches     1936     1936           
=======================================
  Hits        20547    20547           
  Misses        786      786           
  Partials      268      268           
Flag Coverage Δ
unittests 95.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review October 2, 2024 11:16
@BilalQamar95 BilalQamar95 requested a review from a team as a code owner October 2, 2024 11:16
@BilalQamar95 BilalQamar95 self-assigned this Oct 2, 2024
@KristinAoki KristinAoki merged commit a352fd5 into master Oct 21, 2024
11 checks passed
@KristinAoki KristinAoki deleted the bilalqamar/node-v18-upgrade branch October 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants