[FC-0049] feat: Serialize tag data in OpenAssessmentBlocks

[yusuf-musleh]

TL;DR - This PR utilizes changes introduced in openedx/edx-platform#34145 to serialize and include tags data in OpenAssessmentBlocks

What changed?

• The new serialize_tag_data is called and the result (if any) is added to the OLX node

Developer Checklist

• Reviewed the release process
• Translations and JS/SASS compiled
• Bumped version number in openassessment/__init__.py and package.json

Testing Instructions

Follow the testing instruction in openedx/edx-platform#34145 and make sure to setup ora2 locally on this branch, and include a few OpenAssessmentBlocks in the course and apply a few tags on it and then double check that tags-v1 is included in the OLX (if tags are applied to the block)

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

• I've done a visual code review
• I've tested the new functionality

FYI: @openedx/content-aurora

[openedx-webhooks]

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a255a08) 94.95% compared to head (c3e6ed5) 94.95%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2171   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         191      191           
  Lines       20675    20691   +16     
  Branches     1879     1880    +1     
=======================================
+ Hits        19631    19647   +16     
  Misses        780      780           
  Partials      264      264           

Flag	Coverage Δ
unittests	94.95% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[itsjeyd]

Hey @yusuf-musleh, this will need to go through internal review before we can mark it as ready for upstream review, right?

[yusuf-musleh]

Hey @yusuf-musleh, this will need to go through internal review before we can mark it as ready for upstream review, right?

@itsjeyd Yup that's correct. Awaiting review/feedback from @ChrisChV and/or @bradenmacdonald first.

[bradenmacdonald]

I suggest that in TaggedBlockMixin you put these lines of code:

https://github.com/openedx/edx-platform/blob/2cd2f09da1a7cf1a609ca1309a35850458a166c7/cms/lib/xblock/tagging/tagged_block_mixin.py#L51-L54

into a helper function called add_tags_to_node. And then this can just become:

Suggested change

	if hasattr(oa_block, 'serialize_tag_data') and callable(oa_block.serialize_tag_data): # pylint: disable=no-member
	tag_data = oa_block.serialize_tag_data() # pylint: disable=no-member
	if tag_data:
	root.set('tags-v1', tag_data)
	if hasattr(oa_block, 'add_tags_to_node') and callable(oa_block.add_tags_to_node): # pylint: disable=no-member
	# This comes from TaggedBlockMixin
	oa_block.add_tags_to_node(root) # pylint: disable=no-member

[yusuf-musleh]

Agreed, much cleaner. I've updated it, and also updated the edx-platform PR to use it as well.

[ChrisChV]

@yusuf-musleh Looks good 👍

• I tested this: I followed the testing instructions of [FC-0049] feat: Serialize tag data in OLX for blocks edx-platform#34145 and I tested to copy an OpenAssessmentBlocks.
• I read through the code and considered the security, stability and performance implications of the changes.
• Includes tests for bugfixes and/or features added.

[pomegranited]

👍

• I tested this on my devstack by following the steps in the PR
• I read through the code
• I checked for accessibility issues N/A
• Includes documentation N/A
• User-facing strings are extracted for translation N/A

[openedx-webhooks]

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.