-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creating new enterprise group members endpoint #2270
Open
kiram15
wants to merge
19
commits into
master
Choose a base branch
from
kiram15/ENT-9670
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiram15
force-pushed
the
kiram15/ENT-9670
branch
from
October 23, 2024 22:48
bdc5b56
to
ded0c0a
Compare
katrinan029
reviewed
Oct 30, 2024
katrinan029
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! I think we're just missing the sorting piece since we want the members table to be alphabetized per the design specs. https://www.figma.com/design/eMWRd2jVa4Jqc6y7qrUfaa/Groups-Phase-2?node-id=1193-6018&t=PancQEnrxtpLLI1J-1
…into kiram15/ENT-9670
kiram15
force-pushed
the
kiram15/ENT-9670
branch
from
November 6, 2024 21:34
9728a87
to
51ae1ad
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in an endpoint for the data table that is created in this ticket. We will be fetching info about the user (email, date_joined, name) from the enterprise_customer_user, and then fetching the total number of enrollments associated with that enterprise user.
Jira
Members are automatically sorted on full_name, then first_name, then last_name (see example).
Testing:
The link is http://localhost:18000/enterprise/api/v1/enterprise-customer-members/{enterprise-uuid}
Check that each row has an enterprise_customer_user dict with info like first/last name and an enrollment count
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.