Remove unencrypted sap client credentials

CHANGELOG.rst

@@ -17,6 +17,18 @@ Unreleased
 ----------
 * nothing unreleased
 
+[4.25.8]
+----------
+* feat: added migration for removing unencrypted client credentials
+
+[4.25.7]
+----------
+* refactor: removed unencrypted credentials from sap config model.
+
+[4.25.6]
+----------
+* refactor: making unencrypted credentials nullable so after removing refs tests can run
+
 [4.25.5]
 ----------
 * feat: changing django enterprise customer summary columns

enterprise/__init__.py

@@ -2,4 +2,4 @@
 Your project description goes here.
 """
 
-__version__ = "4.25.5"
+__version__ = "4.25.8"

integrated_channels/sap_success_factors/migrations/0023_auto_20240909_1556.py

@@ -0,0 +1,23 @@
+# Generated by Django 3.2.23 on 2024-09-09 15:56
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('sap_success_factors', '0022_auto_20240906_1349'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='sapsuccessfactorsenterprisecustomerconfiguration',
+            name='key',
+            field=models.CharField(blank=True, default='', help_text='OAuth client identifier.', max_length=255, null=True, verbose_name='Client ID'),
+        ),
+        migrations.AlterField(
+            model_name='sapsuccessfactorsenterprisecustomerconfiguration',
+            name='secret',
+            field=models.CharField(blank=True, default='', help_text='OAuth client secret.', max_length=255, null=True, verbose_name='Client Secret'),
+        ),
+    ]

integrated_channels/sap_success_factors/migrations/0024_auto_20240909_1614.py

@@ -0,0 +1,21 @@
+# Generated by Django 3.2.23 on 2024-09-09 16:14
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('sap_success_factors', '0023_auto_20240909_1556'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='sapsuccessfactorsenterprisecustomerconfiguration',
+            name='key',
+        ),
+        migrations.RemoveField(
+            model_name='sapsuccessfactorsenterprisecustomerconfiguration',
+            name='secret',
+        ),
+    ]

integrated_channels/sap_success_factors/models.py

@@ -74,13 +74,6 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
         (USER_TYPE_USER, 'User'),
         (USER_TYPE_ADMIN, 'Admin'),
     )
-    key = models.CharField(
-        max_length=255,
-        blank=True,
-        default='',
-        verbose_name="Client ID",
-        help_text=_("OAuth client identifier.")
-    )
 
     decrypted_key = EncryptedCharField(
         max_length=255,
@@ -137,13 +130,6 @@ def encrypted_key(self, value):
         verbose_name="SAP User ID",
         help_text=_("Success factors user identifier.")
     )
-    secret = models.CharField(
-        max_length=255,
-        blank=True,
-        default='',
-        verbose_name="Client Secret",
-        help_text=_("OAuth client secret.")
-    )
 
     decrypted_secret = EncryptedCharField(
         max_length=255,