-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit learner credit unenrollment event #2190
Conversation
184a039
to
6e4b86e
Compare
setup.py
Outdated
def get_requirements(requirements_file): | ||
def load_requirements(*requirements_paths): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes in this file are just cherry-picked from cookiecutter-django-app to bring it up to date and prevent weird issues parsing base.in.
6e4b86e
to
3681743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are looking good to me. Left a clarifying question about the event-tracking
requirements constraint.
3681743
to
29dad8b
Compare
event type: org.openedx.enterprise.learner_credit_course_enrollment.revoked.v1 event_name: LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKED The motivation for emitting this event is to support event-driven creation of openedx_ledger.Reversal objects. ENT-9213
a939162
to
7780866
Compare
7780866
to
a61ee2d
Compare
event type: org.openedx.enterprise.learner_credit_course_enrollment.revoked.v1
event_name: LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKED
The motivation for emitting this event is to support event-driven creation of openedx_ledger.Reversal objects.
ENT-9213
Merging of this PR is blocked until we can merge and release openedx/openedx-events#380