Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Replace paver update_db. #1799

Merged
merged 1 commit into from
Jul 13, 2023
+2 −2
Merged

docs: Replace paver update_db. #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/development.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ as an example) and run migrations:

.. code-block:: bash
$ paver update_db
$ make migrate
# Or use a more down-to-the-root command (replace aws with your version of config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of your PR, but what is meant by aws here?

Copy link
Contributor

@robrap robrap Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I just remembered that the old call had paver install_prereqs baked in. Does that need to be added here? Also, do we have a Make equivalent for that, or is that something needed later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have make requirements, but I don't think this documentation requires the requirements to be installed. (aws is the old name of the production settings, I believe.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This comment doesn't make sense in this file, because we're using devstack, and it probably doesn't need to be replaced?
  2. In the other file, it probably makes sense to replace aws in the comment and the example command to production.

Since this merged already, I guess we'll see if one of us do a follow-up PR. :)

$ ./manage.py lms migrate --settings=devstack
Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ perform database migrations.

.. code-block:: bash

$ paver update_db
$ make migrate

# Or use a more down-to-the-root command (replace aws with your version of config)
$ ./manage.py lms migrate --settings=aws
Expand Down