Remove unencrypted sap client credentials #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Khan/Added-Encrypted-Credentials-Column-In-SAP-Configuration
…Khan/Data-Migration-For-Encrypted-Credentials-Column-In-SAP-Configuration
…Khan/Data-Migration-For-Encrypted-Credentials-Column-In-SAP-Configuration
MueezKhan246
changed the base branch from
master
to
MueezKhan/Data-Migration-For-Encrypted-Credentials-Column-In-SAP-Configuration
MueezKhan246
force-pushed
the
MueezKhan/Remove-Unencrypted-SAP-Client-Credentials
branch
from
25a323d
to
32bd53a
Compare
…mn-In-SAP-Configuration' of github.com:openedx/edx-enterprise into MueezKhan/Remove-Unencrypted-SAP-Client-Credentials
…guration-From-Code' of github.com:openedx/edx-enterprise into MueezKhan/Migration-For-Removing-Decrypted-Client-Secret-In-SAP-Configuration
…Khan/Added-Encrypted-Client-Secret-In-SAP-Configuration
…Khan/Data-Migration-For-Encrypted-Credentials-Column-In-SAP-Configuration
…ation' of github.com:openedx/edx-enterprise into MueezKhan/Data-Migration-For-Encrypted-Credentials-Column-In-SAP-Configuration
…Khan/Data-Migration-For-Encrypted-Credentials-Column-In-SAP-Configuration
…Khan/Removing-Unencrypted-Credentials-From-Model
…mn-In-SAP-Configuration' of github.com:openedx/edx-enterprise into MueezKhan/Removing-Unencrypted-Credentials-From-Model
…Khan/Removing-Unencrypted-Credentials-From-Model
…of github.com:openedx/edx-enterprise into MueezKhan/Remove-Unencrypted-SAP-Client-Credentials
…efs tests can run
…lable' of github.com:openedx/edx-enterprise into MueezKhan/Removing-Unencrypted-Credentials-From-Model
…of github.com:openedx/edx-enterprise into MueezKhan/Remove-Unencrypted-SAP-Client-Credentials
…Khan/Making-Unencrypted-SAP-Client-Credentials-Nullable
…lable' of github.com:openedx/edx-enterprise into MueezKhan/Removing-Unencrypted-Credentials-From-Model
…of github.com:openedx/edx-enterprise into MueezKhan/Remove-Unencrypted-SAP-Client-Credentials
hamzawaleed01
approved these changes
Sep 10, 2024
Base automatically changed from
MueezKhan/Removing-Unencrypted-Credentials-From-Model
to
master
September 10, 2024 12:25
…Khan/Remove-Unencrypted-SAP-Client-Credentials
checked again to be sure.. |
MueezKhan246
deleted the
MueezKhan/Remove-Unencrypted-SAP-Client-Credentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
added migration file to remove unencrypted sap client credentials
this PR must only be merged when
1st Removing decrypted client secret in sap configuration from code #2228 (merged)
then
2nd Migration for removing decrypted client secret in sap configuration #2230 (merged)
then
3rd Added encrypted client secret in sap configuration #2231 (merged)
then
4th Data migration for encrypted credentials column in sap configuration #2215 (merged)
then
5th Making unencrypted sap client credentials nullable #2236 (merged)
and then
6th Removing unencrypted credentials from model #2220 (merged)
gets deployed
JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8972