Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed user retirement docs and add redirect to its new location #2257

Merged
merged 1 commit into from
May 21, 2024

Conversation

farhan
Copy link
Contributor

@farhan farhan commented May 20, 2024

Ticket: openedx/edx-platform#34276

Removed user retirement docs and add redirect to its new location

Testing

  • Ran ./run_tests.sh without warnings or errors

Screenshot 2024-05-20 at 12 57 40 PM

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

Test Result:

  • Docs tested by generating the html files using following command
pip install -r shared/tools.txt
./develop.sh en_us/install_operations/
  • Redirection from the old url is working fine

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that the pages aren't simply being totally deleted and a redirect set up to the new site?

@feanil
Copy link
Contributor

feanil commented May 20, 2024

@farhan you might not be aware, but we can just delete the RST files and replace them with redirects here: https://github.com/openedx/edx-documentation/blob/master/en_us/shared/conf.py#L9

@farhan farhan force-pushed the farhan/remove-user-retirement-docs branch from 2bd01a3 to cc4ae31 Compare May 21, 2024 07:13
@farhan farhan force-pushed the farhan/remove-user-retirement-docs branch from cc4ae31 to e160fdd Compare May 21, 2024 07:19
@farhan farhan requested review from sarina and feanil May 21, 2024 07:24
@feanil feanil merged commit 7aea74c into openedx:master May 21, 2024
8 checks passed
@farhan farhan deleted the farhan/remove-user-retirement-docs branch May 21, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants