test: Stripe tests clean up and update #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/REV-4019/stripe-tests-cleanup
branch
3 times, most recently
from
19f79f7
to
dc47c99
Compare
julianajlk
force-pushed
the
julianajlk/REV-4019/stripe-tests-cleanup
branch
from
dc47c99
to
647da2e
Compare
christopappas
approved these changes
May 7, 2024
julianajlk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-4019.
This PR uncomments and updates the
Stripeclass tests, and I also updates theStripeCheckoutViewtest to assert the processor response is recorded. Keeping both types of tests so it's clear we have tests for both classes, even though they overlap.I am also updating
handle_processor_responseto convert a'true'/'false'value to Python bool, since this value comes from the frontend as a string. The current code does not cause an issue in production even though the check is not being used as expected, since there are no Payment Intents with status 'requires_action' yet, we are not using the Dynamic Payment Methods flow yet.