refactor!: remove unnecessary contraint requirement and add a comment…

… for xmlsec
openedx · Apr 19, 2024 · d37f44e · d37f44e
1 parent 118bad7
commit d37f44e
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/migrations-mysql8.yml b/.github/workflows/migrations-mysql8.yml
@@ -52,6 +52,9 @@ jobs:
         pip uninstall -y mysqlclient
         pip install --no-binary mysqlclient mysqlclient
         pip uninstall -y xmlsec
+        # pinning xmlsec to a stable release (version: 1.3.13) as the
+        # new release (version: 1.3.14) fails to compile according to
+        # https://github.com/xmlsec/python-xmlsec/issues/314
         pip install --no-binary xmlsec==1.3.13 xmlsec==1.3.13
 
     - name: Initiate Services

diff --git a/requirements/base.txt b/requirements/base.txt
@@ -341,7 +341,6 @@ kombu==5.3.7
     # via celery
 libsass==0.23.0
     # via
-    #   -c requirements/constraints.txt
     #   -r requirements/base.in
     #   django-libsass
 linecache2==1.0.0

diff --git a/requirements/constraints.txt b/requirements/constraints.txt
@@ -32,7 +32,6 @@ idna==2.7
 
 # TODO : Pinning this until we are sure there aren't any breaking changes, then we'll upgrade.
 celery<6.0.0
-libsass==0.23.0
 
 # social-auth-app-django 5.3.0 currently introduces a hanging migration for large table sizes
 # Pinning for now to reduce entropy

diff --git a/requirements/production.txt b/requirements/production.txt
@@ -348,7 +348,6 @@ kombu==5.3.7
     # via celery
 libsass==0.23.0
     # via
-    #   -c requirements/constraints.txt
     #   -r requirements/base.in
     #   django-libsass
 linecache2==1.0.0

diff --git a/requirements/test.txt b/requirements/test.txt
@@ -513,7 +513,6 @@ lazy-object-proxy==1.10.0
     # via astroid
 libsass==0.23.0
     # via
-    #   -c requirements/constraints.txt
     #   -r requirements/base.txt
     #   django-libsass
 linecache2==1.0.0