Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby update to redwood #431

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add ruby update to redwood #431

merged 3 commits into from
Jun 27, 2024

Conversation

ghassanmas
Copy link
Member

@ghassanmas ghassanmas commented Jun 24, 2024

This PR just to sync master with open-release/redwood.master since there are only two commits exists between cut date and now no need for backport.

To be merged before open-release/redwood.2 release

@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jun 26, 2024
@itsjeyd
Copy link

itsjeyd commented Jun 26, 2024

Hi @ghassanmas, thank you for this contribution!

Are the changes ready for review?

@ghassanmas
Copy link
Member Author

@itsjeyd yes it is

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 27, 2024
@itsjeyd
Copy link

itsjeyd commented Jun 27, 2024

@ghassanmas Great!

Hi @openedx/2u-infinity team, this PR is ready for engineering review.

@feanil I'm running into the same issue that I had for 2u-aurora and https://github.com/openedx/frontend-app-learning (can't request reviews from 2u-infinity for PRs against https://github.com/openedx/cs_comments_service). When you get a minute could you please add 2u-infinity to this repo to fix that?

@feanil feanil merged commit 5765a10 into open-release/redwood.master Jun 27, 2024
36 checks passed
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@feanil
Copy link
Contributor

feanil commented Jun 27, 2024

@itsjeyd I think you should be able to tag 2u-infinity on this repo now, I've updated the collaborators.

@itsjeyd
Copy link

itsjeyd commented Jun 27, 2024

@feanil Yep, it's working now. Thanks 👍

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants