-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove Transifex calls for FC-0012 - OEP-58 #2377
feat!: remove Transifex calls for FC-0012 - OEP-58 #2377
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ad69b0f
to
117e781
Compare
117e781
to
0fb6934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shadinaif.
@brian-smith-tcril this one is ready for merge.
I will review and merge later today. Please don't do it earlier, I'm verifying some other parts of this change within credentials. |
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pull
andtx push
commands..po
or.mo
files will be committed into the repos.Makefile
targets and configuration files.Use the OEP-58 JavaScript translations from the Open edX platformdoes not applyRemovenot availabletransifex-client
from requirementsMerge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
## Keep this pull request as a draft to prevent an accidental merge. ##
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.