-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add python311 and python312 CI support #4320
build: add python311 and python312 CI support #4320
Conversation
Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @openedx/course-discovery-maintainers! Would someone be able to review this for us? Thanks! |
044ec6d
to
f55bf82
Compare
@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR didn't run unit tests on python 3.11 and 3.12 versions because these versions weren't available on the docker image and the test suites just skipped unit tests. For the services that run CI on docker, we need to modify Dockerfile as well.
https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059094#step:4:1646
https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059586#step:4:1646 |
@iamsobanjaved or @ichintanjoshi is one of you working on fixing this? |
@feanil I am coming back from vacation on Monday and will take a look into it. |
#4328 is ready for review, it updates the Dockerfile to add support for Python 3.11 and 3.12 |
Description
This PR contains changes for upgrading python 3.8 to python 3.11 & 3.12
Changes include :-
Done as a part of following :-