fix: use different config for different envs #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
reviewed
Mar 22, 2024
Dockerfile
Outdated
| @@ -60,6 +60,7 @@ EXPOSE 8381 | |||
| FROM app as prod | |||
|
|
|||
| ENV DJANGO_SETTINGS_MODULE "course_discovery.settings.production" | |||
| ENV DISCOVERY_CFG "minimal.yml" | |||
There was a problem hiding this comment.
It looks like this would use minimal settings in prod, which I don't think is what we want.
Ali-D-Akbar
force-pushed
the
aakbar/dockerfile-fix-config
branch
from
f292526
to
e8acb33
Compare
DawoudSheraz
approved these changes
Mar 22, 2024
AfaqShuaib09
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes local devstack issues by adding the prod config file name.